Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer locations #286

Merged
merged 19 commits into from Feb 20, 2022
Merged

Developer locations #286

merged 19 commits into from Feb 20, 2022

Conversation

joemasilotti
Copy link
Owner

@joemasilotti joemasilotti commented Feb 17, 2022

This PR continues the work I did in my livestream on Tuesday morning. It adds a location field on the developer form.

To-do

  • Persist Location as nested attribute on Developer
  • Geocode city, state, country via geocoder gem
  • Get time zone via timezone gem
  • Render location on developer profile
  • Render time zone from location
  • Add tests for Location
  • Add tests for LocationComponent
  • Filter by time zone from Location, not Developer
  • Backfill for migration time zone from Developer to Location
  • Update scheduler in production from developers:utc_offset to locations:utc_offset
  • Deploy
  • Run backfills:time_zone

Being handled in #302

  • Remove developers.time_zone and developers.utc_offset
  • Remove conditional validation for locations.latitude and locations.longitude

Pull request checklist

  • Your code contains tests relevant for code you modified
  • You have linted and tested the project with bin/check

@joemasilotti joemasilotti self-assigned this Feb 17, 2022
@joemasilotti joemasilotti marked this pull request as ready for review February 19, 2022 18:49
@joemasilotti joemasilotti merged commit a31ac05 into main Feb 20, 2022
5 checks passed
@joemasilotti joemasilotti deleted the jam/developer-locations branch February 20, 2022 04:34
@joemasilotti joemasilotti mentioned this pull request Feb 27, 2022
2 tasks
@kaushikhande kaushikhande mentioned this pull request Mar 9, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant