Clean up Open Graph meta tags

[joemasilotti]

This PR cleans up how/when Open Graph tags are rendered and tweaks the copy on a few key pages.

Current failing tests are because I can't figure out how to test content_for in a View Component.

Pull request checklist

• Your code contains tests relevant for code you modified
• You have linted and tested the project with bin/check

[radar]

Following from your Twitter thread here: https://twitter.com/joemasilotti/status/1497341331315650560?s=20&t=nc7y6ITf4HnEDPGLhai9LA.

How about:

render(OpenGraphTagsComponent.new, tags: content_for(:open_graph_tags))

Then in the component itself, return the tags if they're present, otherwise render the component's view. This would remove the need for content_for use in the component's view, and the code here then is just that single render line.

[joemasilotti]

Maybe I'm missing something, but doesn't this mean I have to add back in the following block every time I render the component?

<% content_for(:open_graph_tags) do %>
  <%= render OpenGraphComponent.new(...) %>
<% end %>

[davekaro]

I think I prefer the content_for block in every view anyways. It keeps the component simple and more clear in the view what is happening. Why are you trying to remove the content_for block from all the views?

[joemasilotti]

Because it feels like a responsibility every single view shouldn't have. The rendering helper and the component already know about the magic symbol, I'd rather not spread it across the rest of the codebase too.

There's probably a different abstraction I'm missing here, to be honest.

[joemasilotti]

OK I think I have something working locally! I'll commit later today but the gist is to render the content_for in a helper, not the component.

[joemasilotti]

For those following along, I went with something a bit different. Instead of rendering the content_for in the component I've moved that logic to a helper that then renders the component. The helper passes all the arguments down to the component and has an option to render a more specific Open Graph component.

def open_graph_tags(options = {})
  content_for(:open_graph_tags) do
    component = options.delete(:component) || OpenGraphTagsComponent
    render component.new(**options)
  end
end