Revamp messaging with Hotwire #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemasilotti
force-pushed
the
hotwire-messaging
branch
2 times, most recently
from
d1d509a
to
e562b58
Compare
joemasilotti
force-pushed
the
hotwire-messaging
branch
from
e562b58
to
9b52b78
Compare
KonnorRogers
approved these changes
Mar 21, 2022
|
Thank you! I appreciate the review - merging in your changes after CI passes. :D |
topdeveloper-dev
added a commit
to topdeveloper-dev/railsdev.com
that referenced
this pull request
Feb 13, 2023
* First pass at sending a message via Hotwire * Redesign message form to show inline error message * Client-side validation * Remove unused translation * Add test for sending messages via Turbo Stream * Memoize conversation * Remove redundant role="list" joemasilotti/railsdevs.com#334 (comment) * Add feature to CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR closes #333. It uses a Turbo Stream to send messages and append to the list.
Pull request checklist
bin/check