Added ability to submit messages with cmd+Enter (#328). #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemasilotti
requested changes
Mar 18, 2022
| @@ -0,0 +1,11 @@ | |||
| import { Controller } from "@hotwired/stimulus" | |||
|
|
|||
| // Connects to data-controller="form" | |||
There was a problem hiding this comment.
Suggested change
| // Connects to data-controller="form" |
| // Connects to data-controller="form" | ||
| export default class extends Controller { | ||
| cmdEnterSubmit(event) { | ||
| if ((event.ctrlKey == true || event.metaKey == true) && event.code == 'Enter') { |
There was a problem hiding this comment.
Suggested change
| if ((event.ctrlKey == true || event.metaKey == true) && event.code == 'Enter') { | |
| if ((event.ctrlKey == true || event.metaKey == true) && event.code == "Enter") { |
|
|
||
| // Connects to data-controller="form" | ||
| export default class extends Controller { | ||
| cmdEnterSubmit(event) { |
There was a problem hiding this comment.
Suggested change
| cmdEnterSubmit(event) { | |
| submit(event) { |
app/views/messages/_form.html.erb
Outdated
| @@ -1,6 +1,6 @@ | |||
| <div class="border border-gray-300 sm:rounded-lg shadow-sm overflow-hidden focus-within:border-gray-500 focus-within:ring-1 focus-within:ring-gray-500"> | |||
| <%= form.label :body, t(".help"), class: "sr-only" %> | |||
| <%= form.text_area :body, rows: 4, placeholder: t(".placeholder"), class: "block w-full py-3 border-0 sm:rounded-lg sm:rounded-b-none resize-y focus:ring-0 sm:text-sm" %> | |||
| <%= form.text_area :body, rows: 4, placeholder: t(".placeholder"), class: "block w-full py-3 border-0 sm:rounded-lg sm:rounded-b-none resize-y focus:ring-0 sm:text-sm", data: {action: "keydown->form#cmdEnterSubmit"} %> | |||
There was a problem hiding this comment.
Suggested change
| <%= form.text_area :body, rows: 4, placeholder: t(".placeholder"), class: "block w-full py-3 border-0 sm:rounded-lg sm:rounded-b-none resize-y focus:ring-0 sm:text-sm", data: {action: "keydown->form#cmdEnterSubmit"} %> | |
| <%= form.text_area :body, rows: 4, placeholder: t(".placeholder"), data: {action: "keydown->form#cmdEnterSubmit"}, class: "block w-full py-3 border-0 sm:rounded-lg sm:rounded-b-none resize-y focus:ring-0 sm:text-sm" %> |
Just because class can grow so I like to leave it at the end.
…age-keyboard-submit
joemasilotti
approved these changes
Mar 21, 2022
|
Looks great! Thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Pull request checklist
bin/check