Clean up test fixtures #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemasilotti
force-pushed
the
clean-up-test-fixtures
branch
from
6f51472
to
1450709
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR addresses #363 by removing, renaming, and narrowing the scope of a lot of fixtures. The goal is to keep at most 3 but ideally 2 fixtures per class. If anything else more specific is needed for tests then that record should be created manually or an existing fixture should be modified.
To do
test/models/test/components/test/system/test/policies/test/queries/Pull request checklist
bin/check