Move email/notification sending from callbacks to explicit methods #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemasilotti
force-pushed
the
move-notification-callbacks
branch
from
b675971
to
702f687
Compare
This was referenced May 2, 2022
|
@joemasilotti Sorry I got waylaid by other stuff and didn't get back with that extra feedback. But I just quickly skimmed through your latest changes in this PR, looks really great! So clean & readable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR moves callback-triggered email/notification sending to explicit methods.
Pull request checklist
bin/check