New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reply to messages via email #481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODOS:
* Is `mail.from` "safe" - can we trust it actually is that person?
* What about multipart (HTML) email bodies?
* Is reply-to "conversations-#{id}@" the right approach - or should we
explore a header?
* Routing all: :messages isn't sustainable.
Instead of using the conversation ID in the reply-to, instead use a signed ID to ensure it can't be guesses. This should remove the worry of someone faking a `from` header.
|
@fig mentioned on the stream:
|
* if the signed conversation ID is invalid * if the user can't be found
TODO: * Clean up double `if` statement in MessagesMailbox * Bounce email with an an actual mailer letting the business know why it bounced
tysongach
reviewed
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR implements inbound email processing for replying to messages.
Closes #423.
To-dos:
Businesses::Permissionto ensure user is permitted to send the messageQuestions/concerns:
mail.from"safe" - can we trust it actually is that person?Do we need to handle "reply above this line"?Not until I use it in production for a bit.Pull request checklist
bin/checkI added significant changes and product updates to the changelogNot until I remove the feature flag