Warn to seed the database when no Developer records in development #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
joemasilotti
requested changes
Jun 14, 2022
app/views/developers/index.html.erb
Outdated
| @@ -41,6 +41,7 @@ | |||
|
|
|||
| <!-- Paginated list of developers --> | |||
| <div class="col-span-12 md:col-span-9"> | |||
| <%= render Developers::UnseededWarningComponent.new(seedable: Rails.env.development?) %> | |||
There was a problem hiding this comment.
Let's move this to app/views/shared/_main.html.erb:2 so it shows up on every page.
|
|
||
| test "hidden when seedable but developers exist" do | ||
| render_inline UnseededWarningComponent.new(seedable: true) | ||
| assert_no_text("Run bin/rails db:seed") |
There was a problem hiding this comment.
Let's consolidate using parenthesis or not for these assertions.
There was a problem hiding this comment.
Nice catch. I removed them to be consistent
|
@joemasilotti I've updated this PR based on your feedback. Looking sharp
|
|
Excellent - thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Connects to #472; broken out of #484 .
Adds a warning when in the Rails Development environment and the database has no Developer records to seed the database.
bin/check/developers#484 will cover it.