Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS app powered by Turbo Native #496

Merged
merged 48 commits into from Jun 15, 2022
Merged

iOS app powered by Turbo Native #496

merged 48 commits into from Jun 15, 2022

Conversation

joemasilotti
Copy link
Owner

@joemasilotti joemasilotti commented Jun 15, 2022 •
edited

This PR adds support for an iOS app powered by Turbo Native!

It covers a lot of different things, most notably:

  • New endpoints for native authentication
  • Push notification registration and sending when a new message is sent
  • Turbo Native variants and UI changes to hide top-level headers in app
  • Always redirects to sign in (not registration) on auth failure
  • Hides registration links in Turbo Native apps (for now)
  • Revamps Open Graph tags to show shorter ones on Turbo Native apps

Pull request checklist

  • My code contains tests covering the code I modified
  • I linted and tested the project with bin/check
  • I added significant changes and product updates to the changelog

@joemasilotti
Update logo to remove .io
8d65c1d
@joemasilotti
Authentication tokens and API credential checks
57d9085
@joemasilotti
Expose Turbo Native helper and set request variant
d3e113b
@joemasilotti
JavaScript bridge for Turbo Native
c17c9ee
@joemasilotti
Hide footer and part of header on Turbo Native
57440ec
@joemasilotti
Start adding custom titles for Turbo Native
5d731ba
@joemasilotti
Path Configuration for Turbo Native
9f2bac7
@joemasilotti
API authentication for Turbo Native
c44a42f
@joemasilotti
Route Turbo Native auth failures to native sign in
44ecefd
@joemasilotti
Turbo Native custom titles for developer profiles
cfd960f
@joemasilotti
Hide link to /pricing in Turbo Native apps
5831b7a
@joemasilotti
Merge branch 'main' into ios-app
f0a6a83
@joemasilotti
Always redirect to sign in, not registration
7cdd51a
@joemasilotti
WIP
ee92b28
@joemasilotti
Merge branch 'main' into ios-app
aca1971
@joemasilotti
Merge branch 'main' into ios-app
56ce34c
@joemasilotti
More <title> tags for authenticated pages
40b808c
@joemasilotti
More sane spacing on mobile
a4a4d7f
@joemasilotti
WIP
85bfe8b
@joemasilotti
WIP
68e0d0c
@joemasilotti
Merge branch 'main' into ios-app
5cf9869
@joemasilotti
WIP
7b398b1
@joemasilotti
WIP
05da731
@joemasilotti
Merge branch 'main' into ios-app
e67d568
@joemasilotti
WIP
3695cf4
@joemasilotti
Merge branch 'main' into ios-app
d53782a
@joemasilotti
Merge branch 'main' into ios-app
8094710
@joemasilotti
Merge branch 'main' into ios-app
760cfba
@joemasilotti
Ensure /pricing doesn't actually link on iOS
40414be
@joemasilotti
Destroy associated notification token on sign out
561db28
github-code-scanning[bot]
github-code-scanning bot found potential problems Jun 15, 2022
View reviewed changes
app/controllers/api/application_controller.rb Dismissed
@@ -0,0 +1,24 @@
module API
class ApplicationController < ApplicationController
skip_before_action :verify_authenticity_token

Check failure

Code scanning / CodeQL

CSRF protection weakened or disabled High

Potential CSRF vulnerability due to forgery protection being disabled or weakened.
@joemasilotti joemasilotti marked this pull request as ready for review June 15, 2022 04:31
@joemasilotti joemasilotti merged commit f0037ca into main Jun 15, 2022
4 checks passed
@joemasilotti joemasilotti deleted the ios-app branch June 15, 2022 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joemasilotti