Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse inbound emails via Postmark API #588

Merged
merged 8 commits into from Jul 30, 2022
Merged

Parse inbound emails via Postmark API #588

merged 8 commits into from Jul 30, 2022

Conversation

joemasilotti
Copy link
Owner

@joemasilotti joemasilotti commented Jul 30, 2022

This PR is the start of migrating to Postmark's inbound webhook JSON API. It will replace Action Mailbox.

To-do

  • Set up email alias so folks can reply to @railsdevs.com
  • Clean up app/jobs/inbound_email_job.rb:12 - this feels a bit dirty
  • Inform folks that they should remove their email before replying

Pull request checklist

  • My code contains tests covering the code I modified
  • I linted and tested the project with bin/check
  • I added significant changes and product updates to the changelog

For future PR(s):

  • Enable the Feature in production after testing manually a few times
  • Add job to incinerate the InboundEmail after 30 days if successful
  • Rescuing from ActiveRecord::RecordNotFound no-ops – should it email the user?
  • Can reply_to set the name of the recipient?

@@ -0,0 +1,5 @@
module Webhooks
class ApplicationController < ActionController::Base
skip_before_action :verify_authenticity_token, only: :create

Check failure

Code scanning / CodeQL

CSRF protection weakened or disabled High

Potential CSRF vulnerability due to forgery protection being disabled or weakened.
@joemasilotti joemasilotti marked this pull request as ready for review July 30, 2022 20:33
@joemasilotti joemasilotti merged commit 26a4ac4 into main Jul 30, 2022
5 checks passed
@joemasilotti joemasilotti deleted the inbound-emails branch July 30, 2022 21:03
@joemasilotti joemasilotti mentioned this pull request Jul 31, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant