New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow rich text for Developer#bio #638
Conversation
|
Nice work so far! I'd prefer to keep all of the user's inputted text for the bio instead of deleting anything. Can we instead render the markup directly, as in not an HTML It looks like you are already disabling links and images via the HTML renderer. I think that's good enough and exactly what we want! |
|
Excellent! The preview you rendered looks perfect. Let's add the "Markdown supported" text – great idea. Please use the following copy (it can be added below the EXAMPLE TOPICS list):
|
|
It is now just missing non-English translations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks and works great! I only have two tiny requests.
|
Oh, I just noticed one more thing. Developer cards are rendering the plain markdown. Let's update that to remove the markup tags and render plain text. For example:
|
|
This looks great! I made a few tiny tweaks and will merge after CI passes. Thanks for your contribution, @rayhanw. |


Allows markdown for
developer#bio. Closes #633Pull request checklist
bin/checkNotes:
I created a custom renderer object to handle links and images.If the user writes a markdown link/image, it will be saved into the DB but rendered as an empty string (check the custom renderer object above). I'm not sure if this is the best way, or whether actually removing it before the
biois saved would be better. Let me know!I didn't write tests for the custom renderer object because I'm honestly not sure what to test of it and it should also be covered by thedevelopers/rich_textconcern tests.Examples:
Text:
**Lorem ipsum dolor sit amet.**Result:
Text:
Result: