Tell Heroku to build the redesign CSS, too #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| unless system "yarn install && yarn build:redesign" | ||
| raise "Command css:redesign failed, ensure yarn is installed and `yarn build:redesign` runs without errors" | ||
| end |
There was a problem hiding this comment.
system is able to raise a more specific and verbose error if you pass exception: true to it.
https://rubyapi.org/3.1/o/kernel#method-i-system
Suggested change
| unless system "yarn install && yarn build:redesign" | |
| raise "Command css:redesign failed, ensure yarn is installed and `yarn build:redesign` runs without errors" | |
| end | |
| system "yarn install && yarn build:redesign", exception: true |
Rails recently made a similar change to what I'm suggesting. rails/rails@24fbbe0
There was a problem hiding this comment.
Good to know! Thanks for sharing.
I copy-pasted this from cssbundling-rails and jsbundling-rails. But for custom system calls I'll make sure to use exception: true in the future.
benmercerdev
added a commit
to benmercerdev/railsdevs.com
that referenced
this pull request
Oct 28, 2022
* main: (31 commits) Github Actions changes (joemasilotti#717) represent json string with multine string syntax (joemasilotti#716) build: minify CSS via cssnano (joemasilotti#713) Set request variant for redesign requests (joemasilotti#714) Paywall location and timezone filters (joemasilotti#674) Fix tailwind postcss setup (joemasilotti#710) New fonts for the redesign (joemasilotti#708) Don't track `/developers/:id/:code` to Fathom (joemasilotti#706) Refactor `Users::PaywalledComponent` to remove business logic (joemasilotti#705) Tell Heroku to build the redesign CSS, too (joemasilotti#704) Multiple Tailwind CSS configs (for the redesign) (joemasilotti#701) Update to Tailwind CSS v3.2 (joemasilotti#700) Publicly shareable developer profile URLs (joemasilotti#665) Bump nokogiri from 1.13.8 to 1.13.9 (joemasilotti#697) Bump Turbo Package to 7.2.2 & Gem version to 1.3.1 (joemasilotti#696) Compress HTML output via gzip (joemasilotti#688) Bring back 1x and 2x avatars and remove lazy loading (joemasilotti#680) Fix test settings for Rubymine (joemasilotti#679) RailsDevs French Version (joemasilotti#687) Revert manual payments (joemasilotti#681) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fix attempt for #703.