Minify production CSS via cssnano #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Tailwind's recommended method of minifying the CSS via the `cssnano` PostCSS plugin. This drops the final CSS files by about 20kb when `NODE_ENV` is production.
|
20kb?! That's like ¼ reduction in size! Thanks so much for this Andrew. Once CI passes I'm going to do a quick review locally and merge it in if all looks good. |
|
|
benmercerdev
added a commit
to benmercerdev/railsdevs.com
that referenced
this pull request
Oct 28, 2022
* main: (31 commits) Github Actions changes (joemasilotti#717) represent json string with multine string syntax (joemasilotti#716) build: minify CSS via cssnano (joemasilotti#713) Set request variant for redesign requests (joemasilotti#714) Paywall location and timezone filters (joemasilotti#674) Fix tailwind postcss setup (joemasilotti#710) New fonts for the redesign (joemasilotti#708) Don't track `/developers/:id/:code` to Fathom (joemasilotti#706) Refactor `Users::PaywalledComponent` to remove business logic (joemasilotti#705) Tell Heroku to build the redesign CSS, too (joemasilotti#704) Multiple Tailwind CSS configs (for the redesign) (joemasilotti#701) Update to Tailwind CSS v3.2 (joemasilotti#700) Publicly shareable developer profile URLs (joemasilotti#665) Bump nokogiri from 1.13.8 to 1.13.9 (joemasilotti#697) Bump Turbo Package to 7.2.2 & Gem version to 1.3.1 (joemasilotti#696) Compress HTML output via gzip (joemasilotti#688) Bring back 1x and 2x avatars and remove lazy loading (joemasilotti#680) Fix test settings for Rubymine (joemasilotti#679) RailsDevs French Version (joemasilotti#687) Revert manual payments (joemasilotti#681) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Use Tailwind's recommended method of minifying the CSS via the
cssnanoPostCSS plugin. This drops the final CSS files by about 20kb whenNODE_ENVis production.You can test this yourself by pulling this branch, installing deps, and running
Take note of the final file sizes generated to🔥
app/assets/buildsand then run the commands again withNODE_ENV=productionprefixed to see the savingsHere is what I am getting on my machine after multiple runs:
Since you're working on a redesign, I figured this would be the perfect time to introduce this optimization from which you get a pretty significant saving (see above).
Didn't think this needed a changelog entry but lmk and I can add. Feel free to throw this away but I noticed you didn't have it and wanted to get in a contribution😄
Pull request checklist
bin/check