From 2419d97a28b17edc0a4efd8c98523f57858f2d71 Mon Sep 17 00:00:00 2001 From: Johari Date: Wed, 30 Oct 2019 01:58:56 +0800 Subject: [PATCH] fix missing route path & name --- src/Routings/Concerns/Grammar.php | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/Routings/Concerns/Grammar.php b/src/Routings/Concerns/Grammar.php index ea10df5..1a31938 100644 --- a/src/Routings/Concerns/Grammar.php +++ b/src/Routings/Concerns/Grammar.php @@ -46,11 +46,11 @@ public function pathConvention(string $type, string $function, array $attributes */ private function keymapIsString($keymap): array { - if (\is_string($keymap) && Str::length($keymap) > 0) { - return [$keymap]; + if (\is_string($keymap)) { + return (Str::length($keymap) > 0) ? Arr::wrap($keymap) : []; } - return []; + return $keymap; } /** @@ -111,6 +111,10 @@ public function namedConvention(string $type, string $controller, string $functi $names = array_change_key_case($named, \CASE_LOWER); - return Str::lower(collect($names)->get($type)) ?? Str::lower($type . '.' . $controller . '.' . $function); + if (collect($names)->has($type)) { + return Str::lower(collect($names)->get($type, \null)); + } else { + return Str::lower($type . '.' . $controller . '.' . $function); + } } }