New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wnck_window_is_minimized(WnckWindow *window) does not work with JWM. #133

Closed
Donskoy-tabak opened this Issue Aug 30, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@Donskoy-tabak

wnck_window_is_minimized returns 0 always in JWM.
This bug couses incorrect work of some third-party panels and docks.
In other wm wnck_window_is_minimized works correctly.
Example code for test:

define WNCK_I_KNOW_THIS_IS_UNSTABLE

include <libwnck/libwnck.h>

undef WNCK_I_KNOW_THIS_IS_UNSTABLE

//gcc wnck.c $(pkg-config --cflags --libs libwnck-3.0) -o wnck

int main (int argc, char **argv)
{
WnckScreen *screen;
GList *list;

gdk_init (&argc, &argv);

screen = wnck_screen_get_default ();

wnck_screen_force_update (screen);

for (list = wnck_screen_get_windows (screen); list != NULL; list = list->next)
{
WnckWindow *window = WNCK_WINDOW (list->data);
g_print ("%s%s%s [%d]\n", wnck_window_get_name (window),
wnck_window_is_minimized(window) ? " (IS MINIMIZED)" : "",
wnck_window_is_active(window) ? " (IS ACTIVE)" : "",
wnck_window_get_state(window));
}

return 0;
}

bbidulock added a commit to bbidulock/jwm that referenced this issue Aug 30, 2014

fix for issue #133
- _NET_WM_STATE_HIDDEN was not being written when a window
  is minimized.
@bbidulock

This comment has been minimized.

Show comment
Hide comment
@bbidulock

bbidulock Aug 30, 2014

Contributor

Yeah, libwnck is plain stupid. All it has to do is to check WM_STATE to see whether a window is iconic (in accordance with ICCCM 2.0), however, it misinteprets the _NET_WM_STATE_HIDDEN atom instead. I have a libwnck fork that works much better, but still hasn't been fixed in this regard.

Contributor

bbidulock commented Aug 30, 2014

Yeah, libwnck is plain stupid. All it has to do is to check WM_STATE to see whether a window is iconic (in accordance with ICCCM 2.0), however, it misinteprets the _NET_WM_STATE_HIDDEN atom instead. I have a libwnck fork that works much better, but still hasn't been fixed in this regard.

@joewing joewing added the bug label Aug 31, 2014

@joewing joewing added this to the Version 2.2.3 milestone Aug 31, 2014

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Aug 31, 2014

Owner

Thanks @Donskoy-tabak for the report and thanks again @bbidulock for a fix!

Owner

joewing commented Aug 31, 2014

Thanks @Donskoy-tabak for the report and thanks again @bbidulock for a fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment