New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with `<Dynamic>` tag #188

Closed
01micko opened this Issue Jul 1, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@01micko

01micko commented Jul 1, 2015

Couple of problems.

  • it needs a label or else "Dynamic" shows up as the label
  • it does not respect menu heights

A simple screen shot and my code -

<RootMenu label="1" labeled="false" height="24" onroot="3">
<Dynamic label="Bookmarks" icon="about.svg" height="24">exec:$HOME/.jwm/root_menus/menu3</Dynamic>
</RootMenu>
<RootMenu label="2" labeled="false" height="24" onroot="2">
<Dynamic label="Main Menu" icon="puppy.svg" height="24">exec:$HOME/.jwm/root_menus/menu2</Dynamic>
</RootMenu>

screenshot1

Thanks

@01micko

This comment has been minimized.

Show comment
Hide comment
@01micko

01micko Jul 1, 2015

I suppose the first one is not really an issue, but is there a simple solution for the second one? Maybe each entry needs the menu height specified? Hmm.. maybe its me...

01micko commented Jul 1, 2015

I suppose the first one is not really an issue, but is there a simple solution for the second one? Maybe each entry needs the menu height specified? Hmm.. maybe its me...

@01micko

This comment has been minimized.

Show comment
Hide comment
@01micko

01micko Jul 1, 2015

Ok, seems that <Dynamic> should support heights to me. I can work around it with an unlabelled <Menu> in my script ( @zigbert 's script actually) but it's not ideal as we get the arrow in between "Bookmarks" and the menu. We have a similar script for the main menu with the same effect.

01micko commented Jul 1, 2015

Ok, seems that <Dynamic> should support heights to me. I can work around it with an unlabelled <Menu> in my script ( @zigbert 's script actually) but it's not ideal as we get the arrow in between "Bookmarks" and the menu. We have a similar script for the main menu with the same effect.

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Jul 1, 2015

Owner

It should support heights and the default label was just an artifact of how it was implemented. Both should be fixed in snapshot 1149.

Owner

joewing commented Jul 1, 2015

It should support heights and the default label was just an artifact of how it was implemented. Both should be fixed in snapshot 1149.

@joewing joewing added the bug label Jul 1, 2015

@joewing joewing added this to the Version 2.3.2 milestone Jul 1, 2015

@01micko

This comment has been minimized.

Show comment
Hide comment
@01micko

01micko Jul 1, 2015

Thanks!

I'll give 1149 a spin shortly.

01micko commented Jul 1, 2015

Thanks!

I'll give 1149 a spin shortly.

@01micko

This comment has been minimized.

Show comment
Hide comment
@01micko

01micko Jul 1, 2015

Yep, fixed for me, thanks! Closing.

01micko commented Jul 1, 2015

Yep, fixed for me, thanks! Closing.

@01micko 01micko closed this Jul 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment