New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window closing if user click middle button of mouse in taskbar on client #232

Closed
rdnvndr opened this Issue Oct 21, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@rdnvndr
Contributor

rdnvndr commented Oct 21, 2015

Please add window closing if user click middle button of mouse in taskbar on client.
Patch file:

diff -cr jwm-2.1.0/src/taskbar.c jwm-roand/src/taskbar.c
*** jwm-2.1.0/src/taskbar.c 2012-01-21 17:39:19.874691527 +0000
--- jwm-roand/src/taskbar.c 2012-01-21 18:07:43.204610350 +0000
***************
*** 257,262 ****
--- 257,269 ----
              FocusGroup(entry);
           }
           break;
+       case Button2:
+          if (entry) { 
+            ClientEntry *cp;
+            for (cp = entry->clients; cp; cp = cp->next) 
+               DeleteClient(cp->client);
+          }
+          break;
        case Button3:
           ShowClientList(bar, entry);
           break;
@yetanothergeek

This comment has been minimized.

Show comment
Hide comment
@yetanothergeek

yetanothergeek Dec 18, 2015

This is somewhat dangerous, if a clumsy user like me accidentally middle-clicks a task. ( I just lost about 15 minutes work, but it could have been much worse! ) Please revert this, or at least make it optional.

This is somewhat dangerous, if a clumsy user like me accidentally middle-clicks a task. ( I just lost about 15 minutes work, but it could have been much worse! ) Please revert this, or at least make it optional.

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Dec 18, 2015

Owner

I don't have a strong opinion on this, but I can see how it can cause problems. The binding isn't particularly intuitive from my perspective, so I'll revert it. Making bindings more configurable is something I plan to implement.

Owner

joewing commented Dec 18, 2015

I don't have a strong opinion on this, but I can see how it can cause problems. The binding isn't particularly intuitive from my perspective, so I'll revert it. Making bindings more configurable is something I plan to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment