New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the default window icon configurable #246

Closed
joewing opened this Issue Nov 12, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@joewing
Owner

joewing commented Nov 12, 2015

JWM now displays a "square" if there is no application-specific icon specified. This default icon should be configurable.

@joewing joewing added the enhancement label Nov 12, 2015

@joewing joewing added this to the Versio 2.3.5 milestone Dec 6, 2015

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Dec 6, 2015

Owner

Fixed as of snapshot 1355.

Owner

joewing commented Dec 6, 2015

Fixed as of snapshot 1355.

@joewing joewing closed this Dec 6, 2015

@technosaurus

This comment has been minimized.

Show comment
Hide comment
@technosaurus

technosaurus Dec 12, 2015

Contributor

Naming stuff is hard. The current fix sounds like a default tray button for root menus... Window or title icon would fit better for this usage; however it would be great to have a configurabe, generic, default icon.
The xdg specifications list an icon- missing icon in the naming spec that would be a good example in the documents accompanying the source code.

Contributor

technosaurus commented Dec 12, 2015

Naming stuff is hard. The current fix sounds like a default tray button for root menus... Window or title icon would fit better for this usage; however it would be great to have a configurabe, generic, default icon.
The xdg specifications list an icon- missing icon in the naming spec that would be a good example in the documents accompanying the source code.

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Dec 12, 2015

Owner

I like the current name since it’s consistent with the others: ButtonMin, ButtonMax, ButtonMaxActive, ButtonClose, and ButtonMenu (to show the window menu).
A default for root menus would make sense, but I think it would be called something else, perhaps DefaultIcon under TrayStyle? Really, I think the ButtonX options should go under WindowStyle, but that would break compatibility.

Owner

joewing commented Dec 12, 2015

I like the current name since it’s consistent with the others: ButtonMin, ButtonMax, ButtonMaxActive, ButtonClose, and ButtonMenu (to show the window menu).
A default for root menus would make sense, but I think it would be called something else, perhaps DefaultIcon under TrayStyle? Really, I think the ButtonX options should go under WindowStyle, but that would break compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment