New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable menu border #31

Closed
joewing opened this Issue Apr 18, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@joewing
Owner

joewing commented Apr 18, 2013

Currently the color of menu borders is computed based on the background color of the menu. This request is to allow that color to be customizable.
My proposal is to make the "Outline" tag in "MenuStyle" specify the menu border color (currently it specifies the color of the active item) and add "ActiveOutline" to specify the color of the active item. The color in "Outline" or "ActiveOutline" could be extended to support two colors separated by a colon so that the top/left border could be a different color than the bottom/left border.

@joewing joewing modified the milestones: Version 2.3.0, Version 3.0.0 Jan 8, 2015

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Jan 8, 2015

Owner

Added in revision 49033a5.

Owner

joewing commented Jan 8, 2015

Added in revision 49033a5.

@joewing joewing closed this Jan 8, 2015

@Israel-D

This comment has been minimized.

Show comment
Hide comment
@Israel-D

Israel-D Jul 25, 2015

Contributor

This fix has now made borders on all my buttons, previously I had flat buttons.
How do I get my previous look and feel back? The newest configuration changes (removing tasklist style, etc....) do not have as detailed information as I'd like :)

Contributor

Israel-D commented Jul 25, 2015

This fix has now made borders on all my buttons, previously I had flat buttons.
How do I get my previous look and feel back? The newest configuration changes (removing tasklist style, etc....) do not have as detailed information as I'd like :)

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Jul 26, 2015

Owner

I'm still trying to decide out how it should work. I tried making it flat, but I actually liked the old way better with the 3d look. The computed collors are nice too (I haven't actually run into a case where I wanted something else). So I'm trying to make it as simple as possible to configure without taking away too much flexibility.

Owner

joewing commented Jul 26, 2015

I'm still trying to decide out how it should work. I tried making it flat, but I actually liked the old way better with the 3d look. The computed collors are nice too (I haven't actually run into a case where I wanted something else). So I'm trying to make it as simple as possible to configure without taking away too much flexibility.

@Israel-D

This comment has been minimized.

Show comment
Hide comment
@Israel-D

Israel-D Jul 26, 2015

Contributor

@joewing the top panel is fine looking, though I liked the flat buttons better, so an option to remove the border would be nice.
This is especially noticeable in my side panel that has icons only. It looks not so nice now, mainly because I use Numix-Circle icons which are all circular (as you can guess). So the squared boxes around the circles makes it look like more Win95/Gnome1ish... If you can implement some attribute like:

<Tray button="flat"></Tray>

where 'button' can be 'flat' or 'raised' and the default is 'raised' (or whatever) so no attribute is needed for the default behavior that would be fine for me.

Contributor

Israel-D commented Jul 26, 2015

@joewing the top panel is fine looking, though I liked the flat buttons better, so an option to remove the border would be nice.
This is especially noticeable in my side panel that has icons only. It looks not so nice now, mainly because I use Numix-Circle icons which are all circular (as you can guess). So the squared boxes around the circles makes it look like more Win95/Gnome1ish... If you can implement some attribute like:

<Tray button="flat"></Tray>

where 'button' can be 'flat' or 'raised' and the default is 'raised' (or whatever) so no attribute is needed for the default behavior that would be fine for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment