New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tray buttons flat and TaskList buttons with shape? #330

Closed
fredvs opened this Issue Sep 15, 2016 · 8 comments

Comments

Projects
None yet
4 participants
@fredvs

fredvs commented Sep 15, 2016

Hello.

First of all, congratulation for your marvelous JWM.
It is used for polYdev, a FreeBSD disto.

Is it possible, with last release, to have all the Tray-buttons flat (without shape) and the buttons of TaskList with shape ?

I have try but I get or all (Tray and Task buttons) flat or all shaped.

Many thanks.

Fre;D

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Sep 17, 2016

Owner

It's not currently possible, but it should be pretty easy to add. The configuration would probably look something like this:

<TrayStyle decorations="flat">
 ...
</TrayStyle>
<TaskListStyle decorations="motif">
...
</TaskListStyle>
Owner

joewing commented Sep 17, 2016

It's not currently possible, but it should be pretty easy to add. The configuration would probably look something like this:

<TrayStyle decorations="flat">
 ...
</TrayStyle>
<TaskListStyle decorations="motif">
...
</TaskListStyle>

@joewing joewing added the enhancement label Sep 17, 2016

@fredvs

This comment has been minimized.

Show comment
Hide comment
@fredvs

fredvs Sep 19, 2016

Hello Joe.

Perfect, many thanks.

Fre;D

fredvs commented Sep 19, 2016

Hello Joe.

Perfect, many thanks.

Fre;D

@kafran

This comment has been minimized.

Show comment
Hide comment
@kafran

kafran Sep 27, 2016

I vote for this =)

kafran commented Sep 27, 2016

I vote for this =)

@technosaurus

This comment has been minimized.

Show comment
Hide comment
@technosaurus

technosaurus Sep 27, 2016

Contributor

I'm still trying to figure out where/how to modify the tray and button code to accept a "none" background color.

IIRC There was an enhancement issue to support background images for trays, but it may not be useful unless the other enhancement issue requesting individual properties for each tray/button is implemented... because an image that scales well vertically, may not scale well vertically.

This would allow us to use buttons as desktop icons when there's a desktop background image or gradient color. We can already do it with flat background colors. xvesa + jwm with a black background and tray buttons with a matching background as the "desktop icons" only uses ~4Mb of RAM ... Perfect for a doccer image.

Contributor

technosaurus commented Sep 27, 2016

I'm still trying to figure out where/how to modify the tray and button code to accept a "none" background color.

IIRC There was an enhancement issue to support background images for trays, but it may not be useful unless the other enhancement issue requesting individual properties for each tray/button is implemented... because an image that scales well vertically, may not scale well vertically.

This would allow us to use buttons as desktop icons when there's a desktop background image or gradient color. We can already do it with flat background colors. xvesa + jwm with a black background and tray buttons with a matching background as the "desktop icons" only uses ~4Mb of RAM ... Perfect for a doccer image.

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Sep 28, 2016

Owner

This issue is certainly on my near-term to-do list.

@technosaurus Making the background of a tray transparent will either require the use of the composite extension or pseudo-transparency (which is just re-drawing the background of the root window translated to fit the tray). I would lean toward using pseudo-transparency since that’s probably easier and more in-line with the portable and light-weight nature of JWM. In either case, it’s not a trivial change.

The tray background image issue is #40. I don’t think this issue is related though, since this is about the the decorations (borders really).

Owner

joewing commented Sep 28, 2016

This issue is certainly on my near-term to-do list.

@technosaurus Making the background of a tray transparent will either require the use of the composite extension or pseudo-transparency (which is just re-drawing the background of the root window translated to fit the tray). I would lean toward using pseudo-transparency since that’s probably easier and more in-line with the portable and light-weight nature of JWM. In either case, it’s not a trivial change.

The tray background image issue is #40. I don’t think this issue is related though, since this is about the the decorations (borders really).

joewing added a commit that referenced this issue Sep 29, 2016

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Sep 29, 2016

Owner

This is available as of snapshot 1559.

Owner

joewing commented Sep 29, 2016

This is available as of snapshot 1559.

@joewing joewing closed this Sep 29, 2016

@joewing joewing added this to the Version 2.3.7 milestone Sep 29, 2016

@fredvs

This comment has been minimized.

Show comment
Hide comment
@fredvs

fredvs Sep 29, 2016

Many thanks Joe !

fredvs commented Sep 29, 2016

Many thanks Joe !

@fredvs

This comment has been minimized.

Show comment
Hide comment
@fredvs

fredvs Oct 2, 2016

Wow, you added all the parameters for <TaskListStyle> (not only decorations).

So I was able to custom active-inactive background for TaskList too.

Well done and many thanks.

PS: To compile JWM on FreeBSD, automake -a did not work but using:

autogen.sh + configure + make + strip => works like charm, out of the box.

Fre;D

fredvs commented Oct 2, 2016

Wow, you added all the parameters for <TaskListStyle> (not only decorations).

So I was able to custom active-inactive background for TaskList too.

Well done and many thanks.

PS: To compile JWM on FreeBSD, automake -a did not work but using:

autogen.sh + configure + make + strip => works like charm, out of the box.

Fre;D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment