New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not move to the next window in the stacking order #335

Closed
rdnvndr opened this Issue Oct 1, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@rdnvndr
Contributor

rdnvndr commented Oct 1, 2016

I have got two windows. The first window has a normal layer. The second window has a above layer. Also the second window is active. When calls a command "nextstacked" does not move to the first window.

@rdnvndr

This comment has been minimized.

Show comment
Hide comment
@rdnvndr

rdnvndr Oct 3, 2016

Contributor

I'm not sure, but i think for solution of the problem need apply a patch:

diff -cr a/src/clientlist.c b/src/clientlist.c
*** a/src/clientlist.c  2016-09-14 03:57:29.000000000 +0300
--- b/src/clientlist.c  2016-09-25 17:52:46.000000000 +0300
***************
*** 157,163 ****
           /* Skip this window if it no longer exists or is currently in
            * a state that doesn't allow focus.
            */
!          if(np == NULL || !ShouldFocus(np, 1)) {
              continue;
           }

--- 157,163 ----
           /* Skip this window if it no longer exists or is currently in
            * a state that doesn't allow focus.
            */
!          if(np == NULL || !ShouldFocus(np, 1) || np->state.status & STAT_ACTIVE) {
              continue;
           }
Contributor

rdnvndr commented Oct 3, 2016

I'm not sure, but i think for solution of the problem need apply a patch:

diff -cr a/src/clientlist.c b/src/clientlist.c
*** a/src/clientlist.c  2016-09-14 03:57:29.000000000 +0300
--- b/src/clientlist.c  2016-09-25 17:52:46.000000000 +0300
***************
*** 157,163 ****
           /* Skip this window if it no longer exists or is currently in
            * a state that doesn't allow focus.
            */
!          if(np == NULL || !ShouldFocus(np, 1)) {
              continue;
           }

--- 157,163 ----
           /* Skip this window if it no longer exists or is currently in
            * a state that doesn't allow focus.
            */
!          if(np == NULL || !ShouldFocus(np, 1) || np->state.status & STAT_ACTIVE) {
              continue;
           }

@joewing joewing added the bug label Oct 3, 2016

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Oct 3, 2016

Owner

Your patch makes sense and seems to improve the situation. Thanks!

Owner

joewing commented Oct 3, 2016

Your patch makes sense and seems to improve the situation. Thanks!

joewing added a commit that referenced this issue Oct 3, 2016

@rdnvndr rdnvndr closed this Oct 12, 2016

@joewing joewing added this to the Version 2.3.7 milestone Dec 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment