New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the autohiding tray feature in the horizontal layout positioned to the left, makes the menu appear only in the top or bottom instead of left #34

Closed
codesardine opened this Issue Apr 24, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@codesardine
Contributor

codesardine commented Apr 24, 2013

this his what am using in the configuration file for a left tray (autohide="true" halign="left" valign="center" layout="horinzontal") i suggest that the (autohide feature should have instead of "true" his "left" "right" "top" "bottom" so we can chose wich side off the screen the menu appears back again!

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Apr 25, 2013

Owner

This is an interesting issue. I like your solution. Right now I guess my only concern would be breaking compatibility with existing configuration files. One option would be to keep supporting "true" as before and add "left", "right", "top", and "bottom", though I think it's cleaner if the user has to explicitly specify where the tray hides.

Owner

joewing commented Apr 25, 2013

This is an interesting issue. I like your solution. Right now I guess my only concern would be breaking compatibility with existing configuration files. One option would be to keep supporting "true" as before and add "left", "right", "top", and "bottom", though I think it's cleaner if the user has to explicitly specify where the tray hides.

@codesardine

This comment has been minimized.

Show comment
Hide comment
@codesardine

codesardine Apr 25, 2013

Contributor

(supporting "true" as before and add "left", "right", "top", and "bottom") sounds like a good solution as long as the tray hides and appears in the same side with just one tag (exp: "top") will solve all issues to be fair i did not try this on top ,bottom or right but am guessing the same bug appends, keep supporting "true" as before and maybe delete it in the future.
Am testing jwm so anything i find i will give you feedback. (by the way good job with it looks neat and it his very fast works in a 76 mb ppc with no lag)

Contributor

codesardine commented Apr 25, 2013

(supporting "true" as before and add "left", "right", "top", and "bottom") sounds like a good solution as long as the tray hides and appears in the same side with just one tag (exp: "top") will solve all issues to be fair i did not try this on top ,bottom or right but am guessing the same bug appends, keep supporting "true" as before and maybe delete it in the future.
Am testing jwm so anything i find i will give you feedback. (by the way good job with it looks neat and it his very fast works in a 76 mb ppc with no lag)

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Jan 18, 2015

Owner

This should be available in the latest snapshot. "true" and "false" are no longer supported since I'm breaking config compatibility anyway. Now it's "left", "right", "top", "bottom", or "off".

Owner

joewing commented Jan 18, 2015

This should be available in the latest snapshot. "true" and "false" are no longer supported since I'm breaking config compatibility anyway. Now it's "left", "right", "top", "bottom", or "off".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment