New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: separator in menu gets focus if navigated using the Up key #343

Closed
dumblob opened this Issue Nov 17, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@dumblob

dumblob commented Nov 17, 2016

As the title says, separators in menus are getting focused if the menu is navigated with the keyboard Up arrow key.

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Dec 19, 2016

Owner

I'm not able to reproduce this. I've tried opening a (root) menu with separators and then pressing the up arrow. The behavior I see is the highlight goes up (wrapping at the top) and skips over the separators. Is this an old version of JWM perhaps?

Owner

joewing commented Dec 19, 2016

I'm not able to reproduce this. I've tried opening a (root) menu with separators and then pressing the up arrow. The behavior I see is the highlight goes up (wrapping at the top) and skips over the separators. Is this an old version of JWM perhaps?

@dumblob

This comment has been minimized.

Show comment
Hide comment
@dumblob

dumblob Dec 20, 2016

I'm sorry @joewing for forgetting to attach steps to reproduce (hint: you might remind us, leaky heads, to provide steps and materials to reproduce by ading a tiny GitHub Issue template in the repo settings).

Steps with materials and pointers how to reproduce the issue:

  1. Use either JWM 2.3.6 or the current git master version.

  2. Ensure there is <Separator/> directive two or more times successively used at the very end of at least one (sub) menu. E.g.

  <RootMenu onroot="3">
    <Menu icon="folder.png" label="Apps">
      <Program icon="gthumb.png" label="gThumb">gthumb</Program>
      <Program icon="gimp.png" label="Gimp">gimp</Program>
      <Separator/>
      <Separator/>
    </Menu>
  ...
  1. Run JWM, switch to the (sub)menu with the consecutive <Separator/> directives and press the Up key (or any key performing the up action - I have vi bindings, so it's k for me) until the separator gets focused or the menu navigation somehow screwed (e.g. jumping out of the submenu etc.).

dumblob commented Dec 20, 2016

I'm sorry @joewing for forgetting to attach steps to reproduce (hint: you might remind us, leaky heads, to provide steps and materials to reproduce by ading a tiny GitHub Issue template in the repo settings).

Steps with materials and pointers how to reproduce the issue:

  1. Use either JWM 2.3.6 or the current git master version.

  2. Ensure there is <Separator/> directive two or more times successively used at the very end of at least one (sub) menu. E.g.

  <RootMenu onroot="3">
    <Menu icon="folder.png" label="Apps">
      <Program icon="gthumb.png" label="gThumb">gthumb</Program>
      <Program icon="gimp.png" label="Gimp">gimp</Program>
      <Separator/>
      <Separator/>
    </Menu>
  ...
  1. Run JWM, switch to the (sub)menu with the consecutive <Separator/> directives and press the Up key (or any key performing the up action - I have vi bindings, so it's k for me) until the separator gets focused or the menu navigation somehow screwed (e.g. jumping out of the submenu etc.).

@joewing joewing added the bug label Jan 15, 2017

joewing added a commit that referenced this issue Jan 15, 2017

@joewing

This comment has been minimized.

Show comment
Hide comment
@joewing

joewing Jan 15, 2017

Owner

Thanks for reporting this! It should be fixed in snapshot 1573.

Owner

joewing commented Jan 15, 2017

Thanks for reporting this! It should be fixed in snapshot 1573.

@joewing joewing added this to the Version 2.3.7 milestone Jan 15, 2017

@joewing joewing closed this Jan 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment