Merged
Conversation
Author
|
maybe in the future the keys/settings should be stored in lfs |
tahnok
approved these changes
Sep 4, 2022
tahnok
left a comment
tahnok
left a comment
Collaborator
There was a problem hiding this comment.
Nice, thanks for doing this @jackbondpreston !
I agree, using LFS would be a better place for keys, you might even be able to have a command line interface to set up the secret
| totp_state->current_key_offset = 0; | ||
| totp_state->current_index = 0; | ||
| } | ||
| TOTP(keys + totp_state->current_key_offset, key_sizes[totp_state->current_index], timesteps[totp_state->current_index]); |
Collaborator
There was a problem hiding this comment.
IMO, it's a bit clearer to use a subscript here rather than adding an offset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
seems to work fine on the simulator and hardware