Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed simple/ link. #2

Merged
merged 1 commit into from Dec 19, 2012

Conversation

Projects
None yet
3 participants
Contributor

Kyso commented Dec 19, 2012

Weird Github is weird? 

@Kyso Kyso Fixed simple/ link.
Weird Github is weird? 
5770ca4

@joeyespo joeyespo added a commit that referenced this pull request Dec 19, 2012

@joeyespo joeyespo Merge pull request #2 from Kyso/patch-1
Fixed simple/ link.
890ac49

@joeyespo joeyespo merged commit 890ac49 into joeyespo:master Dec 19, 2012

Owner

joeyespo commented Dec 19, 2012

Thanks, Kyso!

Here's hoping GitHub fixes their relative URLs in Readme previews soon.
Once they do, this should be reverted since it breaks relative URLs outside of GitHub.

Owner

joeyespo commented Dec 19, 2012

Relevant issue: github/markup#101

I doubt you'll remember this commit whenever that finally happens.

Btw, this only works when accessing the link from here, not from here. A static link to https://github.com/Kyso/gitpress/tree/master/examples/simple might be required.

Edit: Now it's actually the opposite since you merge-merged it to the master branch.

Owner

joeyespo commented Dec 20, 2012

@FichteFoll Yeah, it's a little bit of a pain relative URLs don't work right. It's even worse that relative images are broken in the same way.

It's leading me to use less linking on blog repositories I also push to GitHub so it doesn't appear "broken" even though the URLs are perfectly valid when hosted anywhere else.

I doubt you'll remember this commit whenever that finally happens.

Created issue #5 to keep track of this =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment