Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily schedule issue, add fact uploading in task #4

Merged
merged 7 commits into from Sep 26, 2019

Conversation

@kreeuwijk
Copy link
Contributor

kreeuwijk commented Jul 18, 2019

This PR improves two things:

  • It ensures the day_of_week attribute is only set on the weekly schedule, preventing recurring corrective changes to the schedule resource when a daily frequency is chosen.
  • It adds an optional uploadfactswhendone parameter to the updatereport task, enabling the refresh of the report data on the Puppet master in one go.
joeypiccola and others added 7 commits Jul 25, 2018
fix last modified data error handling and add support to clean up offline sync service if we error before removing it as part of the regular api logic.
PDK, feature, and bug enhancements
@joeypiccola

This comment has been minimized.

Copy link
Owner

joeypiccola commented Sep 6, 2019

@kreeuwijk I'm kind of learning here. My dev branch was the same as master when you cloned it. That said, I' like to merge your PR to dev before going to master. That said, I see I can do that on my end but will that mess anything up? Thanks.

@joeypiccola joeypiccola changed the base branch from master to dev Sep 26, 2019
@joeypiccola joeypiccola merged commit 88db941 into joeypiccola:dev Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.