Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/update build process #56

Merged
merged 5 commits into from Apr 10, 2019
Merged

Feature/update build process #56

merged 5 commits into from Apr 10, 2019

Conversation

dobromir-hristov
Copy link
Collaborator

This PR updates the build process from using Webpack to Bili (Rollup)

This introduces a breaking change as now users are supposed to import Croppie CSS styles manually for both Browser and Bundle usages.

Users can now however register VueCroppie locally if they want to.

PS: Please keep in mind there is an issue with Croppie with the latest merged PR so a fix is pending: Foliotek/Croppie#617

@jofftiquez
Copy link
Owner

Hi @dobromir-hristov I will give time to review this thanks.

@dobromir-hristov
Copy link
Collaborator Author

I am using this in our production btw and it works alright. There is an issue however with the bundled version of Croppie, which is why I had to create a fork. The author still has not released a new version, as he just merged my fix, without building, so we cant even use the github repo directly.

@dobromir-hristov
Copy link
Collaborator Author

I will test with the latest croppie release tonight, and if it works, we can merge this in.

@jofftiquez
Copy link
Owner

Hello @dobromir-hristov great! Can you send the pr link to croppie maybe I can ask the author to release a new version since he already merged it. Did he merge it to master?

@jofftiquez
Copy link
Owner

Also @dobromir-hristov would you kindly remove the yarn.lock and the dist in this PR? I will build this on my end so I could also perform my testing.

@jofftiquez
Copy link
Owner

Sorry I've been busy these past weeks. Thank you for your efforts on making this plugin better.

@dobromir-hristov
Copy link
Collaborator Author

yarn.lock should stay, if we are to have consistent deps. The dist was left because thats how it was released up to now.

@dobromir-hristov
Copy link
Collaborator Author

Foliotek/Croppie#617 this is the PR. Since then, they have made a 2.6.4 but not released on NPM. Very sloppy maintained library...

@jofftiquez
Copy link
Owner

Thanks @dobromir-hristov I will try to contact the author.

@jofftiquez jofftiquez merged commit fbb0f95 into jofftiquez:master Apr 10, 2019
@dobromir-hristov dobromir-hristov deleted the feature/update-build-process branch April 12, 2019 17:10
@dobromir-hristov
Copy link
Collaborator Author

I think we should do a major version bump, as there is a breaking change in the css. Otherwise ppl might have a bad time imho.

@jofftiquez
Copy link
Owner

@dobromir-hristov 2.0.0 maybe?

@dobromir-hristov
Copy link
Collaborator Author

Yes.

@jofftiquez
Copy link
Owner

jofftiquez commented Apr 13, 2019 •
edited

@dobromir-hristov uploaded v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dobromir-hristov @jofftiquez