Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The DualRing and HourGlass do not require asset files. #35

Merged
merged 2 commits into from Jul 31, 2018
Merged

The DualRing and HourGlass do not require asset files. #35

merged 2 commits into from Jul 31, 2018

Conversation

CaiJingLong
Copy link
Contributor

Replace the image file with CustomPainter.
Then The DualRing and HourGlass do not require asset files.

@jogboms jogboms added the enhancement New feature or request label Jul 30, 2018
@jogboms
Copy link
Owner

jogboms commented Jul 30, 2018

Wow! This is cool @CaiJingLong

@aagarwal1012 can you take a look here?

aagarwal1012
aagarwal1012 requested changes Jul 30, 2018
View reviewed changes
Copy link
Collaborator

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CaiJingLong Great Work 😄, but before merging fix all the formatting issues.

@CaiJingLong
Copy link
Contributor Author

I use vscode auto save to formatted code.
Because I modified the default number of single line characters from 80 to 160, so maybe my code looks different from the project.
If the code has a formatting problem, please help me to fix it.

@jogboms
Copy link
Owner

jogboms commented Jul 31, 2018

Nice work @CaiJingLong.
Are we good with this, @aagarwal1012 so i can push a new release.

@aagarwal1012
Copy link
Collaborator

@CaiJingLong Thanks 👍
@jogboms You can push the new release.

@jogboms jogboms merged commit 7306565 into jogboms:master Jul 31, 2018
@masashi-sutou masashi-sutou mentioned this pull request Dec 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aagarwal1012 aagarwal1012 aagarwal1012 approved these changes

Assignees

@aagarwal1012 aagarwal1012

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CaiJingLong @jogboms @aagarwal1012