Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request for a speed argument #43

Closed
Tremx389 opened this issue Oct 13, 2018 · 2 comments
Closed

Request for a speed argument #43

Tremx389 opened this issue Oct 13, 2018 · 2 comments
Labels
enhancement New feature or request

Comments

@Tremx389
Copy link

Please add an optional argument that can be used to specify the speed of the animation.
This can be extremely useful feature in UX customization, and shouldn't be more then a few lines of code.
@gsunit
Copy link

gsunit commented Oct 13, 2018

Why don't you try a PR?

@jogboms
Copy link
Owner

jogboms commented Oct 14, 2018

Thank you @Tremx389, It sure would be a worthy addition, due to how swamped work hours can get, do you mind laying out how you want this to go maybe in a PR as @gsunit suggested?

@jogboms jogboms added the enhancement New feature or request label Oct 14, 2018
jogboms added a commit that referenced this issue Dec 28, 2018
@jogboms
feat: duration parameter
70b113b 
Closes #43
@jogboms jogboms mentioned this issue Dec 28, 2018
Merged
jogboms added a commit that referenced this issue Dec 28, 2018
@jogboms
release: 3.1.0 (#47)
2c6fff2 
* fix: state disposed before ticker

Fixes #46

* chore: handle analysis issues

* feat: duration parameter

Closes #43

* chore: code clean up

* chore: update changelog
@masashi-sutou masashi-sutou mentioned this issue Dec 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Tremx389 @jogboms @gsunit