Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColumnReader and sink can cause deadlock on host-side bus #4

Closed
johanpel opened this issue Feb 23, 2018 · 1 comment
Closed

ColumnReader and sink can cause deadlock on host-side bus #4

johanpel opened this issue Feb 23, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@johanpel
Copy link
Member

When a ColumnReader has delivered all elements to the stream, as far as the sink is concerned, the ColumnReader is done doing its job. Thus it might reset the ColumnReader before all bus transfers on the host-side of the bus have been handled by the ColumnReader. This can cause a deadlock on the host side bus as the resetted ColumnReader will not acknowledge any incoming transfers that might still be open from a large burst request.

Solution is probably to provide a "done" signal on the output of the ColumnReader, or to "un-fix" the burst length so we never burst over our last byte of interest.

@johanpel johanpel self-assigned this Feb 23, 2018
johanpel added a commit that referenced this issue Feb 23, 2018
@johanpel johanpel added the bug Something isn't working label Feb 23, 2018
johanpel added a commit that referenced this issue Feb 26, 2018
* Temporary fix for issue #4

* Fixes #6

* Support SNAP on ADKU3 FPGA card
johanpel added a commit that referenced this issue Feb 26, 2018
* CAPI SNAP support tested on ADKU3

* Add Echo platform that uses STDIO for debugging

* Moved software builds to CMake

* Temporary fix for issue #4

* Fixes #6

* Update docs
@johanpel
Copy link
Member Author

johanpel commented Jun 4, 2018

Users can use the unlock stream for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant