From 1fe4a71f5be10f182277b6008d212c7f40ced2e4 Mon Sep 17 00:00:00 2001
From: "Michael S. Molina" <70410625+michael-s-molina@users.noreply.github.com>
Date: Thu, 19 Jan 2023 12:22:57 -0500
Subject: [PATCH] feat: Adds a separator to Select All option (#22776)

---
 superset-frontend/.storybook/preview.jsx           | 2 +-
 superset-frontend/src/components/Select/Select.tsx | 1 +
 superset-frontend/src/components/Select/styles.tsx | 4 +++-
 3 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/superset-frontend/.storybook/preview.jsx b/superset-frontend/.storybook/preview.jsx
index a83b6e102e50..967e96a40ddc 100644
--- a/superset-frontend/.storybook/preview.jsx
+++ b/superset-frontend/.storybook/preview.jsx
@@ -87,5 +87,5 @@ addParameters({
       ],
     },
   },
-  controls: { expanded: true },
+  controls: { expanded: true, sort: 'alpha' },
 });
diff --git a/superset-frontend/src/components/Select/Select.tsx b/superset-frontend/src/components/Select/Select.tsx
index 70ca4e690334..ac119423c88a 100644
--- a/superset-frontend/src/components/Select/Select.tsx
+++ b/superset-frontend/src/components/Select/Select.tsx
@@ -467,6 +467,7 @@ const Select = forwardRef(
           {selectAllEnabled && (
             <Option
               id="select-all"
+              className="select-all"
               key={SELECT_ALL_VALUE}
               value={SELECT_ALL_VALUE}
             >
diff --git a/superset-frontend/src/components/Select/styles.tsx b/superset-frontend/src/components/Select/styles.tsx
index b954a04fc7a8..cf9613d1c8e8 100644
--- a/superset-frontend/src/components/Select/styles.tsx
+++ b/superset-frontend/src/components/Select/styles.tsx
@@ -52,7 +52,9 @@ export const StyledSelect = styled(AntdSelect, {
     .ant-select-arrow .anticon:not(.ant-select-suffix) {
       pointer-events: none;
     }
-
+    .select-all {
+      border-bottom: 1px solid ${theme.colors.grayscale.light3};
+    }
     ${
       oneLine &&
       `