Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirement handling with manifest.yaml #15

Merged
merged 1 commit into from Jul 4, 2022
Merged

requirement handling with manifest.yaml #15

merged 1 commit into from Jul 4, 2022

Conversation

emphasize
Copy link
Contributor

Fixes: #14

simple addition to pull dependencies using yaml, replacing requirements.txt / requirements.sh to be able to install on different distros without additional steps

predominantly to invoke pako to be able to install on different distros
Copy link
Owner

@johnbartkiw johnbartkiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I currently don't have a working dev setup for mycroft so I can't easily test the PR. It looks fine but if there are issues I would appreciate you submitting fixes.

@johnbartkiw johnbartkiw merged commit ebd3275 into johnbartkiw:master Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use manifest.yaml to manage dependencies
2 participants