add fuzzy matching capabilities #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tackles two main flaws: The station to be played is picked from the top of the list (NodeList). Since this not always reflects the uttered station (eg a request for "Deutschlandfunk" plays the stream of "Deutschlandfunk Nova" as a result - while "Deutschlandfunk" would be an option) fuzzy matching is introduced to ensure the best match is played. Secondly, a TTS or otherwise butchered utterance (like with the example above if it understands "Deutschlandfunk Nowa" (w)) would result in "station not found". This inconvenience is intercepted by utilizing the APIs fuzzy matching capability. In this case the request is performed twice with the top suggested station (cherry picked from commit b95005b)
johnbartkiw
approved these changes
Jul 4, 2022
|
that's for sure. Not expected that responsiveness, i already found an artifact that doesn't need to be there. |
|
I hate projects that don't respond to PRs quickly so I try and respond in a reasonable time if the PR looks good and helps, even if I'm not as active as I should be. :) If you want to do a cleanup PR to handle any dangling old code I'd be glad to accept. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Closes: #17 #16
The request routine is rewritten allowing one additional api call if a search term is found (If no suggestion is given the while loop will exit) . This allows to leverage suggestions for the TuneIn API in case mycroft misunderstood/misspelled the requested station.
Fuzzy matching is introduced to sort the request for the correct station uttered.
In tandem these two additions should make the request more consistent/convenient.