Modify TuneIn to use the AudioService #7

benklop · 2019-04-05T03:42:48Z

using the audioservice so mycroft handles stop and gets better integration with other audio services

johnbartkiw · 2019-04-05T16:53:26Z

Thanks for the pull request. I like the changes but one of my test case stations using search string "KEXP" doesn't work for some reason with the new audio service. I took a quick peek but I couldn't find anything obvious of why or any logging. Could you possibly take a look to see if you can spot anything?

benklop · 2019-04-09T21:47:50Z

sure, i'll see what I can figure out!

benklop · 2019-04-09T22:47:10Z

it worked fine for me:

 play kexp                                                                                                                                                                                                                                                            
 >> Just a second                                                                                                                                                                                                                                                    
 >> Now playing KEXP-FM from tune in

benklop · 2019-04-09T22:49:46Z

of course, if i try it again immediately, i get this:

play kexp
 >> Just one moment while I look for that                                                                                                                                                                                                                      
 >> I'm not sure how to play kexp

benklop · 2019-04-09T22:54:22Z

every other attempt I made to play that station, both from cli and stt seems to work okay.

johnbartkiw · 2019-04-09T22:55:39Z

For me it says that it finds the station but I get no audio. If you're getting audio then it might just be something in my setup here.

benklop · 2019-04-09T23:32:33Z

@johnbartkiw that's possible. I previously installed vlc and set it to be my default audio backend, because otherwise I was getting some things (emby streams that did not use mp3) playing on a chromecast in the house instead of locally! you might check the /var/log/mycroft/audio.log to see if there's something similarly odd going on for you

johnbartkiw · 2019-04-12T19:41:00Z

Checking the logs everything looks fine but still no audio.

12:37:16.162 - mycroft.audio.speech:mute_and_speak:123 - INFO - Speak: Just a second
12:37:21.558 - mycroft.audio.speech:mute_and_speak:123 - INFO - Speak: Now playing KEXP-FM from tune in
12:37:25.265 - mycroft.audio.audioservice:stop:263 - DEBUG - stopping all playing services
12:37:25.266 - mycroft.audio.audioservice:play:370 - DEBUG - Using default backend (local)
12:37:25.273 - simple__init_:add_list:72 - INFO - Track list is ['http://live-mp3-128.kexp.org/kexp128.mp3']
12:37:25.274 - simple__init__:play:138 - INFO - Call SimpleAudioServicePlay
12:37:25.277 - simple__init__:_play:79 - INFO - SimpleAudioService.play
12:37:25.281 - urllib3.connectionpool - DEBUG - Starting new HTTP connection (1): live-mp3-128.kexp.org:80
12:37:53.844 - mycroft.audio.audioservice:stop:263 - DEBUG - stopping all playing services
12:37:53.845 - simple__init:stop:143 - INFO - SimpleAudioServiceStop

I'm not sure what to check next.

benklop · 2019-04-23T23:17:08Z

next thing I would try is to try the audio backend with the URL in that logging manually. what backend are you using? is it mpg123?

benklop · 2019-04-23T23:19:11Z

At least in my test, it plays fine on the command line, both from VLC and from mpg123

johnbartkiw · 2019-04-24T01:00:11Z

Hard coding the URL gives me the same results. How do you test the AudioService from the command line outside of a skill?

benklop · 2019-04-24T01:03:57Z

I did it by running mpg123 http://live-mp3-128.kexp.org/kexp128.mp3 and vlc http://live-mp3-128.kexp.org/kexp128.mp3 at the command line. The mpg123 test is more or less exactly what mycroft does behind the scenes IIRC, vlc is done a bit differently because it's got a python library, but it still uses the same vlc config files and such so should behave the same

benklop · 2019-04-24T01:13:04Z

your log indicates you're using the default SimpleAudioService to play. That uses mycroft's play_mp3 behind the scenes, as you can see here: https://github.com/MycroftAI/mycroft-core/blob/dev/mycroft/audio/services/simple/__init__.py#L101-L102. Since this was using play_mp3 itself before this pull request, I'm not sure how it could make a difference.

benklop · 2019-04-24T01:20:53Z

possibly https://github.com/johnbartkiw/mycroft-skill-tunein/pull/7/files#diff-743b1adbf37db12e16e01ef62a6f7d72L32 should be removed since play_mp3 isn't actually used here any more

johnbartkiw · 2019-04-24T01:38:14Z

It was working fine with the straight calls to mpg123 so calling that from the command line doesn't really test anything different for me. Any chance the service is misinterpreting the MIME type and using something other than play_mp3?

benklop · 2019-04-24T04:56:15Z

that sounds like a possibility. I checked the content type returned with curl, and got an empty reply:

$ curl -I http://live-mp3-128.kexp.org/kexp128.mp3
curl: (52) Empty reply from server

however, https://github.com/MycroftAI/mycroft-core/blob/dev/mycroft/audio/services/simple/__init__.py#L27-L39 looks like it would correctly guess mp3 based on the extension. even if it fell through to None, the default action is to use mp3.

benklop · 2019-04-24T04:57:16Z

This weekend i can try using the simple audio service and see if maybe i can reproduce

andlo · 2019-12-27T23:57:18Z

I would like to see this change to, as using the play_mp3 directly do give problem, as other skills cant tell/see that there is audio going on. If using audioservice then other skills would know that.
I have problems in Auto-volume skill when using tunein-skill as the auto-volume dont know speaker is making noice, and keeps messure the mic level, which is going bananas when radio is playing.

andlo · 2019-12-28T00:50:03Z

If adding the mime type to the audio_service.play then KEXP radio station and other stations which return empty conttype will work (if they ofcause is mp3 content)
Maybe a check first if contenttype is empty set it to audio/x-mpeg.

this work for me

self.audio_service.play((self.stream_url,'audio/x-mpeg'), utterance,)

johnbartkiw · 2020-01-02T17:22:25Z

What would people think about switching over to VLC since there do seem to be issues with play_mp3 in general? If you check out my IHeartRadio skill I use VLC in the context of the audio service there. Would that work if I moved this skill to be the same?

andlo · 2020-01-02T17:59:03Z

I would prefear to use audioservice and let the mycroftinstallation deside the audiobackend.

If not using audioservice other skills dosnt know if speaker is in use or not and tht can give some problems.

johnbartkiw · 2020-01-02T18:13:04Z

My only problem with this pull request is that it doesn't work for me as I still get no audio. @andlo are you able to test it and verify that it works fine for you?

andlo · 2020-01-02T18:16:19Z

I got it working also with kexp and danisk radio DR P1

I had to change audioservice call to include streamtype

self.audio_service.play((self.stream_url,'audio/x-mpeg'), utterance,)

andlo · 2020-01-02T20:56:30Z

I am not that good githubber....I have forked benklop:master as he has made the change to use audioservice. I have made changes to help with the missing content-type in some streams, and it looks like it is working. BUt I dont know how to pull that back up. Do I first pull it to benklop:master, and then @benklop can merge and pull back to you or how do one do this ?

mexican1973 · 2020-01-03T23:00:35Z

Can you test for me if this station would work with those commits. I am getting an error in tunein when trying to play this station:
--> play "klassik lounge easy listening radio"
klassik with K, you have to enter it manually by typing
thanks

andlo · 2020-01-03T23:11:29Z

:( no it dossnt play :(
I did also just set the contenttype to audio/x-mpeg, which helped on some channels I were trying. But if the stream isnt audio/x-mpeg which just is a good guess and most radiostreams are I think, then we have to figure out what to do.....

I am not good at analysing and dosnt have much knoledeg on audio streams. But maybe if you open the stream in VLC or mplayer it could tell more what it is and then we could make some logic to set right content-type to streams without or with wrong type.

andlo · 2020-01-03T23:35:56Z

testing with mpg123 I get this output:

(.venv) pi@picroft1:/opt/mycroft/skills/web-terminal-skill $ mpg123 -t http://stream.klassikradio.de/lounge/mp3-192/tunein/play
High Performance MPEG 1.0/2.0/2.5 Audio Player for Layers 1, 2 and 3
        version 1.25.10; written and copyright by Michael Hipp and others
        free software (LGPL) without any warranty but with best wishes
[src/resolver.c:305] error: Resolving klassikradio.hoerradar.de:80: Name or service not known
[src/httpget.c:606] error: Unable to establish connection to klassikradio.hoerradar.de
main: [src/mpg123.c:685] error: Access to http resource http://stream.klassikradio.de/lounge/mp3-192/tunein/play failed.
(.venv) pi@picroft1:/opt/mycroft/skills/web-terminal-skill $

trying with curl -I I get

(.venv) pi@picroft1:/opt/mycroft/skills/web-terminal-skill $ curl -I  http://stream.klassikradio.de/lounge/mp3-192/tunein/play
HTTP/1.1 302 Found
Access-Control-Allow-Origin: *
Cache-Control: no-cache, must-revalidate
Content-Type: audio/mpeg
Expires: Fri, 03 Jan 2020 23:30:41 GMT
Location: http://klassikr.streamabc.net/klr-lounge-mp3-192-2214671?sABC=5r0sprn1%231%23q78773sq0qnr75qsp6384r562636573n%23gharva&amsparams=playerid:tunein;skey:1578094241
Server: Caddy
Status: 302 Moved Temporarily
X-Powered-By: PHP/7.3.8
Date: Fri, 03 Jan 2020 23:30:41 GMT

(.venv) pi@picroft1:/opt/mycroft/skills/web-terminal-skill $

I notise Content-Type: audio/mpeg which should be same as Content-Type: audio/x-mpeg.

What I could se were a solution is using audioserver and add contenttype to empty streams. And then let the user if one wantto change the audio server backend to vlc. That would make the skill easy to install, and use, but if some streams isnt working user has to change audioserver backend too vlc. But the skill by itself dossnt use vlc directly and mycroft and other skills arnt getting confused.

mexican1973 · 2020-01-04T00:07:15Z

sorry didnt get that. Does it mean I should install VLC on my picroft installation ?
Or do you say the content type audio/mpeg should be added to the coding ?

andlo · 2020-01-04T00:09:17Z

It means it dosnt work by the default mpg123 as backend. But if VLC is backend I think it would work. VLC do play that exact stream.

mexican1973 · 2020-01-04T00:10:39Z

How do I set VLC as backend in my installation ? Where is that config ?
Do I need to install VLC on picroft ?

andlo · 2020-01-04T00:13:40Z

Sorry I dont know....Never used it but i seen reference to it in the mycroft.conf. Maybe tehre is some doc on mycroft.ai?

my best gues is install vlc (only the cli version) and then set backend in mycroft.conf

https://github.com/MycroftAI/mycroft-core/blob/dev/mycroft/configuration/mycroft.conf#L112

mexican1973 · 2020-01-04T00:28:20Z

I installed VLC now on my installation, still not playing.
What do i need to put in mycroft.conf ? There is already a setting part for VLC by default.
What should I change?

andlo · 2020-01-04T00:29:06Z

I dont know.....sorry.

mexican1973 · 2020-01-04T00:52:26Z

ok now when I type the command in the client it says now l´playing...
but I cant hear anything and I also dont get any error message anymore.
play klassik lounge easy listening radio
seems the original error is gone but still not playing

mexican1973 · 2020-01-04T01:21:52Z

Hi John.
Could you please merge this PR into the master to be able to have audio service ?
Thanks

JarbasAl · 2020-01-04T01:23:44Z

__init__.py

                    # Ignore entries that are marked as unavailable
                    self.mpeg_url = entry.getAttribute("URL")
                    self.station_name = entry.getAttribute("text")
                    # this URL will return audio/x-mpegurl data. This is just a list of URLs to the real streams
                    self.stream_url = self.get_stream_url(self.mpeg_url)
-                    self.audio_state = "playing"
+                    LOG.debug("Found stream URL: " + self.stream_url)
+                    self.audio_service = AudioService(self.bus)


suggestion: move self.audio_service = AudioService(self.bus) into initialize, you can reuse the audio service object this way

JarbasAl · 2020-01-04T01:24:11Z

__init__.py

@@ -87,17 +89,20 @@ def CPS_match_query_phrase(self, phrase):

        return phrase, CPSMatchLevel.GENERIC, phrase

+    def stop(self):
+        pass


you can just remove this, no need to include an empty stop method

JarbasAl · 2020-01-04T01:49:30Z

__init__.py

@@ -25,6 +25,7 @@
 from xml.dom.minidom import parseString

 from mycroft.skills.common_play_skill import CommonPlaySkill, CPSMatchLevel
+from mycroft.skills.audioservice import AudioService


you can also remove from mycroft.util import play_mp3

mexican1973 · 2020-01-06T00:28:12Z

Hey John. I really would like to use your skill.
Can you do the change to use VLC as the default backend player ?
Would be great. Thanks
getting an error when trying to play the station "klassik lounge easy listening radio"

johnbartkiw · 2020-01-06T06:03:49Z

Hey I'm going to update it in the next day or two to use VLC and audio service. It's just a busy time right now with the new year so I haven't had the time. I haven't accepted this PR because it just didn't work for me. I should be able to make the move to VLC pretty easy with a separate change.

johnbartkiw · 2020-01-07T05:54:26Z

I've updated the main branch to utilize AudioService and VLC as the backend. If this ends up solving problems for people then I will close this PR.

mexican1973 · 2020-01-07T12:46:07Z

I have a question @johnbartkiw . Do I have to change something in the mycroft.conf file ?
What exactly ?

mexican1973 · 2020-01-07T12:46:48Z

Also why does it say "This branch has conflicts" in init.py that have to be resolved ?

johnbartkiw · 2020-01-07T16:51:03Z

This branch has conflicts because of the changes in the PR to the .py file don't match up with the changes I made on the main branch. You should be using the main branch and not this branch at this point.

mexican1973 · 2020-01-09T22:43:36Z

Sorry. I reinstalled the skill again with your updates i guess but its still not working. I had changed before the mycroft.conf to default backend "vlc". Should i put local again? What else should i check?
Its not playing any station but i can here the assistant voice.

johnbartkiw · 2020-01-09T23:08:20Z

Without more information I don't know if you've just got a bad client state or something else. The skill works fine on both my dev machine and my Mark-1. I didn't touch the mycroft.conf on either of those so it's possible yours is in a bad state?

mexican1973 · 2020-01-09T23:55:46Z

Hello. I pulled again mycroft-core to fix it. Didnt work. I uninstalled vlc and reinstalled your skill. Also nothing. Only other thing is that i have mopidy installed. Maybe i should also remove it? Otherwise i do a fresh entire install.

johnbartkiw · 2020-01-10T00:00:24Z

Anything in the logs or debug output? Doesn't work doesn't really give me anything to go on.

benklop added 5 commits April 4, 2019 19:45

use audio_service

eb0450e

adjust setting up the audio_service

1a39116

add utterance to CPS_start

dd1a8f1

try again

5c42331

wait while starting stream

bf37b79

andlo mentioned this pull request Jan 2, 2020

Stations not playing then Mycroft hangs? #9

Open

JarbasAl reviewed Jan 4, 2020

View changes

Modify TuneIn to use the AudioService #7

Are you sure you want to change the base?

Modify TuneIn to use the AudioService #7

Conversation

benklop commented Apr 5, 2019

johnbartkiw commented Apr 5, 2019

benklop commented Apr 9, 2019

benklop commented Apr 9, 2019

benklop commented Apr 9, 2019

benklop commented Apr 9, 2019

johnbartkiw commented Apr 9, 2019

benklop commented Apr 9, 2019

johnbartkiw commented Apr 12, 2019

benklop commented Apr 23, 2019

benklop commented Apr 23, 2019

johnbartkiw commented Apr 24, 2019

benklop commented Apr 24, 2019

benklop commented Apr 24, 2019

benklop commented Apr 24, 2019

johnbartkiw commented Apr 24, 2019

benklop commented Apr 24, 2019

benklop commented Apr 24, 2019

andlo commented Dec 27, 2019

andlo commented Dec 28, 2019

johnbartkiw commented Jan 2, 2020

andlo commented Jan 2, 2020

johnbartkiw commented Jan 2, 2020

andlo commented Jan 2, 2020

andlo commented Jan 2, 2020

mexican1973 commented Jan 3, 2020

andlo commented Jan 3, 2020

andlo commented Jan 3, 2020

mexican1973 commented Jan 4, 2020

andlo commented Jan 4, 2020

mexican1973 commented Jan 4, 2020

andlo commented Jan 4, 2020

mexican1973 commented Jan 4, 2020

andlo commented Jan 4, 2020

mexican1973 commented Jan 4, 2020

mexican1973 commented Jan 4, 2020

JarbasAl Jan 4, 2020 • edited

Choose a reason for hiding this comment

JarbasAl Jan 4, 2020 • edited

Choose a reason for hiding this comment

JarbasAl Jan 4, 2020

Choose a reason for hiding this comment

mexican1973 commented Jan 6, 2020

johnbartkiw commented Jan 6, 2020

johnbartkiw commented Jan 7, 2020

mexican1973 commented Jan 7, 2020

mexican1973 commented Jan 7, 2020

johnbartkiw commented Jan 7, 2020

mexican1973 commented Jan 9, 2020

johnbartkiw commented Jan 9, 2020

mexican1973 commented Jan 9, 2020

johnbartkiw commented Jan 10, 2020

JarbasAl Jan 4, 2020 •

edited

JarbasAl Jan 4, 2020 •

edited