-
-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Implement client side rendering #483
Merged
johnbillion
merged 478 commits into
client-side-rendering-feature
from
client-side-rendering
Nov 4, 2023
Merged
WIP: Implement client side rendering #483
johnbillion
merged 478 commits into
client-side-rendering-feature
from
client-side-rendering
Nov 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tomjn
reviewed
Mar 21, 2020
johnbillion
force-pushed
the
client-side-rendering
branch
from
April 3, 2020 22:51
a0b23ff
to
72468be
Compare
This was referenced Jul 24, 2020
29 tasks
This was referenced May 13, 2021
# Conflicts: # .github/workflows/test.yml # assets/query-monitor.js # classes/Backtrace.php # classes/Plugin.php # classes/QueryMonitor.php # collectors/db_queries.php # collectors/http.php # collectors/logger.php # collectors/php_errors.php # collectors/request.php # collectors/timing.php # composer.json # dispatchers/Html.php # output/Html.php # output/html/assets.php # output/html/assets_scripts.php # output/html/assets_styles.php # output/html/conditionals.php # output/html/db_queries.php # output/html/logger.php # output/html/overview.php # output/html/php_errors.php # package.json # phpcs.xml.dist # readme.txt
johnbillion
changed the base branch from
develop
to
client-side-rendering-feature
November 4, 2023 15:29
# Conflicts: # package-lock.json # package.json
johnbillion
merged commit Nov 4, 2023
6c0d836
into
client-side-rendering-feature
13 of 30 checks passed
Just wondering if this is functional yet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts us down the path of switching over Query Monitor's output to client-side rendered React components.
This has numerous benefits including:
There's still lots to do, but the concept has been proven.
See #291.
Progress
Aims
Partial client-side rendering. The main panel container and its menu tabs will remain server-side rendered for the time being. Individual panel contents will be converted to client-side rendering.Publish the UI components as an NPM packageConsiderations
wp.i18n
isn't bundled with WP prior to 5.0.Usage
Per-panel Tasks
The existing collectors and outputters in QM are very well separated, but nevertheless as each panel is worked on the following actions may need to be made:
Panel Progress
overview
admin
assets_scripts
assets_styles
block_editor
cache
caps
conditionals
db_callers
db_components
db_dupes
db_queries
doing_it_wrong
environment
headers
hooks
http
languages
logger
multisite
php_errors
raw_request
request
theme
timing
transients
UI Component Progress
Nope
The following panels will remain server-side rendered:
debug_bar