Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow non-true options to override defaults #146

Open
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant

mcolyer commented May 14, 2012

I would like to be able to put this:

guard 'jasmine-headless-webkit', :full_run => false, :all_on_start => false do

in my guard file and not have it run the full set of tests. Since it doesn't use the command line it passes through opts.each { |k, v| @options[k] = v if v }. Unfortunately this line prevents my :full_run option from being used as it's value is false, so it doesn't override the default true value.

I think this is the proper fix but I'm not exactly sure why the if v was there in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment