John Britton johndbritton

Organizations

@github @p2pu @48hourapps @githubtraining @glean @education
@johndbritton
  • @johndbritton 56fbaee
    bind global hotkey for dropbox
@johndbritton
Question
@johndbritton
johndbritton closed pull request johndbritton/japan#2
@johndbritton
Commenting feature for application
@johndbritton
@johndbritton
johndbritton commented on pull request johndbritton/japan#2
@johndbritton

This should be capitalized.

johndbritton opened pull request johndbritton/japan#2
@johndbritton
Commenting feature for application
2 commits with 6 additions and 0 deletions
johndbritton created repository johndbritton/japan
johndbritton commented on pull request education/classroom#11
@johndbritton

this is the current state of the app. Looking good. I would like to start pushing forward on the invitation of users. Onward :fast_forward:

johndbritton commented on pull request education/classroom#11
@johndbritton

s/affect/effect

johndbritton commented on pull request education/classroom#11
@johndbritton

'is' in a method name usually implies returning a boolean, maybe call this #ensure_organization_admin

johndbritton commented on pull request education/classroom#11
@johndbritton

I'd recommend renaming to #organization_admin?

johndbritton commented on pull request education/classroom#11
@johndbritton

I'm going to get some metrics to see what the time actually is for each page request. You might want to take a look at https://github.com/peek/peek

johndbritton deleted branch comments at johndbritton/japan
@johndbritton
johndbritton closed pull request johndbritton/japan#1
@johndbritton
Add comments to app
@johndbritton
@johndbritton
  • @johndbritton e045f6b
    implement comment feature
johndbritton commented on pull request johndbritton/japan#1
@johndbritton

You might want to extend this implementation.

johndbritton opened pull request johndbritton/japan#1
@johndbritton
Add comments to app
1 commit with 3 additions and 0 deletions
johndbritton created repository johndbritton/japan
johndbritton commented on pull request education/classroom#11
@johndbritton

Another thing to think about, what happens when a user that's associated with a classroom is removed from the owners team? This is another place wh…

johndbritton commented on pull request education/classroom#11
@johndbritton

I would suggest Class, but that's already taken too. It's true that the hardest part of writing software is naming things well. You could also keep…