ES6 friendly #1042

Closed
szepeviktor opened this Issue Nov 30, 2013 · 18 comments

Projects

None yet

3 participants

@szepeviktor

Good morning! I see you have a lot of issues.
Please consider making MEjs AMD friendly
https://github.com/umdjs/umd

Thank you!

@ron666
Collaborator
ron666 commented Aug 10, 2016

@szepeviktor Closing old issues. If you'd like to reopen this, let us know. Thanks!

@ron666 ron666 closed this Aug 10, 2016
@szepeviktor

I think a global JavaScript is not modern.
Please consider implementing it, it is a copy&paste job.

As of now AMD is not modern :(
It is ES6 module time.

@ron666
Collaborator
ron666 commented Aug 10, 2016

@szepeviktor Thanks for your comments. We'll look to implement this soon

@ron666 ron666 reopened this Aug 10, 2016
@ron666 ron666 added the Feature label Aug 10, 2016
@ron666
Collaborator
ron666 commented Sep 1, 2016

@szepeviktor Can you provide some guidance about what's required to convert a plugin into a ES6 module, please? I'm not well familiarized with it

@szepeviktor

Try this page https://github.com/systemjs/systemjs/blob/master/docs/es6-modules-overview.md

+36204242498
Ezen a készüléken sok az elütés.
Elnézést!

On September 1, 2016 1:49:24 PM CEST, Rafael Miranda notifications@github.com wrote:

@szepeviktor Can you provide some guidance about what's required to
convert a plugin into a ES6 module, please? I'm not well familiarized
with it

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#1042 (comment)

@szepeviktor

Google for
jquery plugin es6 module

+36204242498
Ezen a készüléken sok az elütés.
Elnézést!

On September 1, 2016 1:49:24 PM CEST, Rafael Miranda notifications@github.com wrote:

@szepeviktor Can you provide some guidance about what's required to
convert a plugin into a ES6 module, please? I'm not well familiarized
with it

You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#1042 (comment)

@ron666
Collaborator
ron666 commented Sep 4, 2016

@szepeviktor Thanks I'll check this

@ron666
Collaborator
ron666 commented Oct 1, 2016

@szepeviktor Please take a look into 3.x-dev-es6 branch and let me know what else needs to be placed there to make it work completely. This will be a second iteration once 3.x-dev branch is released

@szepeviktor

Thank you!

While searching the code of that branch I cannot find define (AMD module) or export (ES6 module).
Please advise.

@szepeviktor
szepeviktor commented Oct 2, 2016 edited

Although I've found window.MediaElement = mejs.MediaElement;

I think there should be a global release and an ES6 module release.

"Global guys" (99%) do not know what to do with an ES6 module,
"JavaScript guys" dislike scripts with globals.

@ron666
Collaborator
ron666 commented Oct 2, 2016

What I did was just to take all the code right now written and then translating it into ES6 entirely. I'm not creating a module; the code itself is in ES6 but given that I don't have a lot of experience with it I needed to know what else do I need to do.

@szepeviktor
szepeviktor commented Oct 2, 2016 edited

Basically JavaScript modules are self-contained parts of a software. Modules may depend on other modules.

Each and every module has a return value. It is passed to the module depending on it, thus calling it.
Click the link above.

@ron666 ron666 changed the title from AMD friendly to ES6 friendly Oct 11, 2016
@albell
albell commented Nov 21, 2016

+1. This is really useful for webpack based workflows.

@ron666 ron666 added the In Progress label Dec 4, 2016
@ron666
Collaborator
ron666 commented Jan 3, 2017

@szepeviktor can you please start reviewing the mejs-ES6 branch and provide feedback about it? It's still work in progress but another pair of eyes will help me to speed this up; also the idea is to use Travis to test code

@ron666
Collaborator
ron666 commented Jan 4, 2017

Yes, this was removed in a push I made today

@ron666
Collaborator
ron666 commented Jan 8, 2017

@szepeviktor I only need to complete more unit tests and the file to test DOM and this feature will be ready 100%. Just FYI

@ron666 ron666 added Completed and removed In Progress labels Jan 15, 2017
@ron666
Collaborator
ron666 commented Jan 15, 2017

Unit tests and DOM file for testing completed. Now all code is in ES6 specification and it will be pushed tomorrow as part of the 3.0 version. Closing this ticket now

@ron666 ron666 closed this Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment