Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"currentSrc" is called from wrong object in GA plugins #1686

Closed
ivanteoh opened this issue Feb 4, 2016 · 1 comment
Closed

"currentSrc" is called from wrong object in GA plugins #1686

ivanteoh opened this issue Feb 4, 2016 · 1 comment

Comments

@ivanteoh
Copy link
Contributor

ivanteoh commented Feb 4, 2016

player.currentSrc should be player.media.currentSrc in mep-feature-universalgoogleanalytics.js and mep-feature-googleanalytics.js
@ivanteoh ivanteoh mentioned this issue Feb 4, 2016
Merged
johndyer added a commit that referenced this issue Feb 24, 2016
@johndyer
Merge pull request #1687 from ivanteoh/fix-ga
5bf36bb 
Fix wrong "currentSrc" call in ga plugins. #1686
@rafa8626
Copy link
Contributor

@ivanteoh Closing this since PR was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivanteoh @rafa8626