2.6.6 - Adding inline horizontal volume control #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added outline to focused buttons - added aria-controls and title attributes to buttons
disabling ios3 bugfix workaround to add posters in native mode
Merge branch 'master' of github.com:gavinlynch/mediaelement
|
Hello, its says there is code attached but i can't see any code or file for downloading. Regards, Michael |
|
Thanks so much for this. I've used your ideas to introduce the feature into the main code branch. I can't merge this pull request but your work was great! |
|
No problem John, glad to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the inline horizontal volume control I created for a project I was working on.