From 4457109eb710c856feb8bccaf3797cb42fceceed Mon Sep 17 00:00:00 2001 From: Alicia Lopez Date: Wed, 19 Aug 2020 09:19:09 -0700 Subject: [PATCH] fix: return value for validateLint (#482) --- lib/landing_session.js | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/landing_session.js b/lib/landing_session.js index 371e1db..0911093 100644 --- a/lib/landing_session.js +++ b/lib/landing_session.js @@ -137,8 +137,12 @@ class LandingSession extends Session { return true; } - const linted = await runAsync('make', ['lint']); - return linted; + try { + await runAsync('make', ['lint']); + return true; + } catch { + return false; + } } async tryCompleteLanding(patch) { @@ -216,6 +220,8 @@ class LandingSession extends Session { '`git node land --continue`.'); process.exit(1); } + } else { + cli.ok('Lint passed cleanly'); } this.startAmending();