Harmonization of the FileReader #1

johnjohndoe opened this Issue May 3, 2011 · 0 comments


None yet

1 participant


The use and meaning of local variables in FileReader readline and readLineBackwards are not consistent. Especially, the character position at which the reader sits after one while loop in readLineBackwards is another then it is in readLine. That makes it difficult to use the class without knowledge about the inner semantics.
Further, readLineBackwards can be simplified by getting rid of the redundant if-clauses used before and within the while loop. That needs some brain power of course :-}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment