Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ship ./configure #131

Closed
johnkerl opened this issue Mar 1, 2017 · 7 comments
Closed

ship ./configure #131

johnkerl opened this issue Mar 1, 2017 · 7 comments

Comments

@johnkerl
Copy link
Owner

@johnkerl johnkerl commented Mar 1, 2017

Currently http://johnkerl.org/miller-releases/miller-5.0.0/doc/build.html#Building_from_source requires

autoreconf -fiv
./configure
make
make install

The first step can be avoided by shipping the configure scripts along with accompanying artifacts. But, the clean target also needs to be updated to not clobber them.

@Jared-Prime

This comment has been minimized.

Copy link

@Jared-Prime Jared-Prime commented Mar 7, 2017

+1 I ran into this issue yesterday as the OS I was using at the time ( Fedora ) doesn't have the package available. I was unable to build from source as autoreconf -fiv wasn't happy on that particular OS either

@johnkerl

This comment has been minimized.

Copy link
Owner Author

@johnkerl johnkerl commented Sep 7, 2019

OK. This whole autotools thing confuses me mightily (Miller's ./configure support was added by the incomparable @0-wiz-0, not myself) but I have been making a habit of running autoreconf -fiv more often on commits, in particular on every release.

@aborruso

This comment has been minimized.

Copy link
Contributor

@aborruso aborruso commented Sep 7, 2019

but I have been making a habit of running autoreconf -fiv more often on commits, in particular on every release.

I do it every time too

@johnkerl

This comment has been minimized.

Copy link
Owner Author

@johnkerl johnkerl commented Sep 7, 2019

I should clarify, I am running it before commits and pushing it, hopefully so that others don't have to as often.

@0-wiz-0

This comment has been minimized.

Copy link
Contributor

@0-wiz-0 0-wiz-0 commented Sep 7, 2019

So I think the autotools point-of-view is that developers (i.e. people using the git HEAD) can (and should) just run autoreconf -fiv && ./configure.
For the others, make dist will create a tarball that includes a usable configure script already.
(This file will need to be uploaded to the github for each release, github doesn't create such files for us, sadly.)
Does this help?

@johnkerl

This comment has been minimized.

Copy link
Owner Author

@johnkerl johnkerl commented Sep 7, 2019

@0-wiz-0 it does -- thanks!! :)

@johnkerl

This comment has been minimized.

Copy link
Owner Author

@johnkerl johnkerl commented Sep 8, 2019

1349b8c clarifies the build-doc wording at http://johnkerl.org/miller-releases/miller-head/doc/build.html.

Thanks everyone for your patience!

@johnkerl johnkerl closed this Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.