Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Corrected typo in DynamicFactory javadoc and made the interfaces static

  • Loading branch information...
commit 0ebbf3a7c85339fc277d54a9cb2e7ddb6a2e9189 1 parent 02672b6
@johnmay authored
View
8 src/main/org/openscience/cdk/DynamicFactory.java
@@ -604,7 +604,7 @@ public static ConstructorKey key(Class<?> intf, Class<?>... types) {
/**
- * Find a constructor those parameters are assignable from the provided
+ * Find a constructor whose parameters are assignable from the provided
* key.
*
* @param key a key to find the constructor for
@@ -1094,7 +1094,7 @@ public String toString() {
* implements. This interface is constructor injectable allowing us to test
* the registration using this method.
*/
- public interface InterfaceProvider {
+ public static interface InterfaceProvider {
/**
* Access the interfaces for a given class
@@ -1111,7 +1111,7 @@ public String toString() {
*
* @param <T>
*/
- public interface CreationModifier<T> {
+ public static interface CreationModifier<T> {
public void modify(T instance);
}
@@ -1166,7 +1166,7 @@ public T create(Object[] objects) throws InvocationTargetException,
*
* @param <T> the type of object that will be created
*/
- public interface Creator<T> {
+ public static interface Creator<T> {
/**
* Create a new instance with the provided object parameters.
View
2  src/test/org/openscience/cdk/DynamicFactoryTest.java
@@ -183,7 +183,7 @@ public void testRegister_Constructor_Modifier() throws Exception {
DynamicFactoryTestMock.class.getConstructor(String.class),
modifier));
- assertNotNull(factory.ofClass(ICDKObject.class));
+ assertNotNull(factory.ofClass(ICDKObject.class, "empty"));
// verify the modifier was invoked once
Please sign in to comment.
Something went wrong with that request. Please try again.