New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve React detection #113

Merged
merged 2 commits into from Sep 10, 2018

Conversation

Projects
None yet
2 participants
@developit
Contributor

developit commented Sep 8, 2018

This adds detection logic that supports React 16+ when bundled (via webpack, rollup, etc). Instead of relying on attributes or a global React installation, it looks for a property React attaches to the root element when it renders.

/cc @rviscomi

Improve React detection
This adds detection logic that supports React 16+ when bundled (via webpack, rollup, etc). Instead of relying on attributes or a global React installation, it looks for a property React attaches to the root element when it renders.

@developit developit referenced this pull request Sep 8, 2018

Merged

Add Preact detection. #114

@johnmichel johnmichel self-assigned this Sep 10, 2018

@johnmichel

This comment has been minimized.

Owner

johnmichel commented Sep 10, 2018

LGTM!

Thanks!

@johnmichel johnmichel merged commit 5164ae7 into johnmichel:master Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment