Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Ember version detection #138
Thanks for this @tancnle! And apologies for not getting to this much sooner.
I don't know too much about ember, but I assume global variables wouldn't persist for many sites bundled with webpack/parcel/rollup? Do you think it would be better to look for DOM properties instead of globals like we did for React? (can be something we work on later, doesn't have to block this PR)