Consolidate metrics code and linker parameter extraction.#101
Merged
Conversation
* Add injection timing metrics for hot reload performance tracking This commit adds comprehensive timing metrics to InjectionNext that allow client apps to track hot reload performance. The metrics include: - Processing time: Time to find target and compilation command - Compilation time: Time spent compiling the modified file - Linking time: Time spent linking the dynamic library - Total time: End-to-end injection time Changes: - Extended protocol with InjectionMetrics command type - Added InjectionMetricsTracker class using Codable for JSON serialization - Modified link() method to return linking duration - Integrated metrics tracking throughout injection flow - Added sendMetrics() method in NextCompiler using existing sendCommand - Client receives metrics and posts configurable notification The metrics include a notification_name field allowing extensibility without protocol changes. Metrics are sent for both successful and failed injections. * Use INJECTION_METRICS_NOTIFICATION constant from InjectionLite Update InjectionLite submodule to include the notification constant definition and use it instead of a hardcoded string. Depends on: johnno1962/InjectionLite#18 --------- Co-authored-by: Karim Alweheshy <karim.alweheshy@reddit.com>
johnno1962
force-pushed
the
metrics
branch
2 times, most recently
from
1a4c3b4 to
a19f04e
Compare
johnno1962
force-pushed
the
metrics
branch
4 times, most recently
from
591dcec to
4f287b5
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+151
to
+163
| case .metrics: | ||
| guard let metricsJSON = readString() else { | ||
| return error("Unable to read metrics JSON") | ||
| } | ||
| if let data = metricsJSON.data(using: .utf8), | ||
| let metricsDict = try? JSONSerialization.jsonObject(with: data) as? [String: Any], | ||
| let notificationName = metricsDict["notification_name"] as? String { | ||
| NotificationCenter.default.post( | ||
| name: NSNotification.Name(notificationName), | ||
| object: nil, | ||
| userInfo: metricsDict | ||
| ) | ||
| } |
There was a problem hiding this comment.
The error message 'Unable to read metrics JSON' should be more descriptive to help with debugging. Consider including context about what operation was being performed.
| let encoder = JSONEncoder() | ||
| encoder.keyEncodingStrategy = .convertToSnakeCase | ||
| guard let jsonData = try? encoder.encode(metrics), | ||
| let jsonString = String(data: jsonData, encoding: .utf8) else { |
There was a problem hiding this comment.
Silent failure in JSON encoding could hide important errors. Consider logging when metrics encoding fails to aid in debugging.
Suggested change
| let jsonString = String(data: jsonData, encoding: .utf8) else { | |
| let jsonString = String(data: jsonData, encoding: .utf8) else { | |
| log("Failed to encode metrics to JSON:", metrics) |
| let toolchain = xcodeDev+"/Toolchains/XcodeDefault.xctoolchain" | ||
| let frameworks = Bundle.main.privateFrameworksPath ?? "/tmp" | ||
| var testingOptions = "" | ||
| func link(object: String, dylib: String, arch: String) -> (String, Double)? { |
There was a problem hiding this comment.
The return tuple (String, Double) is not self-documenting. Consider using a named tuple like (dylib: String, linkingTimeMs: Double) or a dedicated struct for better API clarity.
| let compilationTimeMs = (now - compilationStartTime) * 1000 | ||
| currentMetrics?.compilationTimeMs = compilationTimeMs | ||
| detail(String(format: "⚡ Compiled in %.0fms", compilationTimeMs)) | ||
|
|
There was a problem hiding this comment.
The regex pattern #\"([ $()])"# and replacement \"\\\\$1\" are not self-explanatory. Consider adding a comment explaining what characters are being escaped and why.
Suggested change
| // Escape spaces, dollar signs, and parentheses in arguments to safely pass them to the shell. | |
| // This prevents issues with shell interpretation of these special characters. |
…ection metrics - Add bazelTarget field to InjectionMetricsTracker - Normalize sourcePath to workspace-relative before sending to client - Discover Bazel app target using BazelAQueryParser - Remove need for client-side enrichment logic Server now sends fully enriched metrics with: - sourcePath: workspace-relative path (e.g., 'Modules/Feature/File.swift') - bazelTarget: discovered app target (e.g., '//Modules/Feature:FeatureSampleApp')
…tion allow bazel target injection
Owner
Author
|
@karim-alweheshy, there was a couple of small fixes to review in InjectionLite in. the last commit johnno1962/InjectionLite@91abadd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.