Karim/metrics#103
Merged
Merged
Conversation
…ection metrics - Add bazelTarget field to InjectionMetricsTracker - Normalize sourcePath to workspace-relative before sending to client - Discover Bazel app target using BazelAQueryParser - Remove need for client-side enrichment logic Server now sends fully enriched metrics with: - sourcePath: workspace-relative path (e.g., 'Modules/Feature/File.swift') - bazelTarget: discovered app target (e.g., '//Modules/Feature:FeatureSampleApp')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds server-side enrichment for injection metrics by discovering Bazel targets and normalizing file paths before sending to clients.
Changes
bazelTargetfield toInjectionMetricsTrackersourcePathto workspace-relative before sending to clientBazelAQueryParserBenefits
Server sends fully enriched metrics:
sourcePath: workspace-relative path (e.g.,Modules/Feature/File.swift)bazelTarget: discovered app target (e.g.,//Modules/Feature:FeatureSampleApp)Client benefits:
Testing
swift build