Environment capture.#119
Merged
Merged
Conversation
johnno1962
force-pushed
the
worktree2
branch
from
4c91261 to
37cebe2
Compare
johnno1962
force-pushed
the
worktree2
branch
from
37cebe2 to
06f0e5e
Compare
johnno1962
force-pushed
the
worktree2
branch
3 times, most recently
from
f18f36a to
d10dfe3
Compare
johnno1962
force-pushed
the
worktree2
branch
3 times, most recently
from
d95caca to
d7cf925
Compare
johnno1962
force-pushed
the
worktree2
branch
from
d7cf925 to
bb527dc
Compare
johnno1962
force-pushed
the
worktree2
branch
16 times, most recently
from
b72d8ff to
88a30ce
Compare
johnno1962
force-pushed
the
worktree2
branch
from
2761c95 to
7e9598f
Compare
johnno1962
force-pushed
the
worktree2
branch
3 times, most recently
from
510a01c to
56bfd33
Compare
johnno1962
force-pushed
the
worktree2
branch
3 times, most recently
from
4bc5005 to
23081bc
Compare
johnno1962
force-pushed
the
worktree2
branch
from
23081bc to
22f6320
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements environment variable capture for Swift frontend commands to improve injection reliability. The changes enable the InjectionNext system to preserve and replay the build environment when recompiling injected sources.
Changes:
- Added environment variable capture in the swift-frontend.sh proxy script
- Updated compiler invocation to apply captured environment during recompilation
- Refactored metrics tracking and compilation caching logic
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| SwiftRegex5 | Updated subproject commit reference |
| Sources/InjectionNextC/include/InjectionClient.h | Removed unused COMMANDS_VERSION macro definition |
| Sources/InjectionNext/InjectionNext.swift | Added error handling override and enhanced trace framework condition checks |
| README.md | Added documentation about COMPILATION_CACHE_ENABLE_CACHING incompatibility and /Applications requirement |
| InjectionLite | Updated subproject commit reference |
| App/feedcommands/main.mm | Added environment capture header and buffered write implementation |
| App/InjectionNext/swift-frontend.sh | Modified to capture environment variables and updated version to 2.0 |
| App/InjectionNext/NextCompiler.swift | Added environment field to Compilation struct, refactored metrics tracking, and implemented environment variable application during recompilation |
| App/InjectionNext/MonitorXcode.swift | Changed recompiler to static property and updated comment tense |
| App/InjectionNext/InjectionServer.swift | Enhanced error message with INJECTION_PROJECT_ROOT guidance |
| App/InjectionNext/InjectionNext-Bridging-Header.h | Added InjectionNextSalt.h import |
| App/InjectionNext/InjectionHybrid.swift | Refactored injection timing logic and moved lastInjected tracking to class level |
| App/InjectionNext/Info.plist | Bumped build version |
| App/InjectionNext/FrontendServer.swift | Implemented environment variable parsing and applied captured environment during command processing |
| App/InjectionNext/Experimental.swift | Updated references to use static recompiler and moved lastInjected to InjectionHybrid |
| App/InjectionNext.xcodeproj/project.pbxproj | Added script phase to generate random COMMANDS_VERSION and updated package versions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johnno1962
force-pushed
the
worktree2
branch
2 times, most recently
from
ffc554a to
de09c67
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 17 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johnno1962
force-pushed
the
worktree2
branch
4 times, most recently
from
dcdb0bc to
d948427
Compare
johnno1962
force-pushed
the
worktree2
branch
from
d948427 to
47487a0
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 17 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 18 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capturing proxy environment
Mapping macro plugin paths
Bazel macro puin paths.