Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to broken master #56

Merged
merged 1 commit into from Jul 9, 2019

Conversation

Projects
None yet
4 participants
@adrw
Copy link
Collaborator

commented Jul 6, 2019

master was broken with following error. Fixed by removing description key from frontmatter query.

Error:

There was an error in your GraphQL query:

- Unknown field 'description' on type 'MdxFrontmatter'.

File: ../packages/gatsby-theme-digital-garden/src/templates/note.js
@@ -11,7 +11,6 @@ export const pageQuery = graphql`
body
frontmatter {
title
description

This comment has been minimized.

Copy link
@adrw

adrw Jul 6, 2019

Author Collaborator

Fixes broken master

@@ -21,11 +21,7 @@ export default props => (
})}
/>
<Layout>
{'*' in props && (

This comment has been minimized.

Copy link
@adrw

adrw Jul 6, 2019

Author Collaborator

Condition would never be met in latest Gatsby version meaning that SEO would never update on return to index after navigating the site. This now properly updates title and SEO tags when navigating back to home page.

Fix to broken master
master was broken with following error. Fixed by removing description key from frontmatter query.

Error:
There was an error in your GraphQL query:
- Unknown field 'description' on type 'MdxFrontmatter'.
File: ../packages/gatsby-theme-digital-garden/src/templates/note.js

Also fixes SEO not updating when navigating back to home page from another page.

@adrw adrw force-pushed the adrw:adrw/20190705.Fix branch from 9980795 to 3d0ea4d Jul 6, 2019

@adrw

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 6, 2019

@johno Release 0.1.0 is currently broken, this fixes it and will require another release. Thanks!

@ChristopherBiscardi

This comment has been minimized.

Copy link
Collaborator

commented Jul 6, 2019

@johno are we deprecating this repo in favor of gatsby-theme-notes?

@adrw

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 9, 2019

@johno @ChristopherBiscardi If this repo isn't going to have continued active development, I'd be happy to accept ownership transfer and continue work on it. If this ends up being deprecated, I'll continue work on it in my fork. Thanks again for this great simple theme that you and the other contributors built! 👍

@johnletey

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Also, I'd be more than happy to help out @adrw continue developing/maintaining this theme if there ever is an ownership/maintainership transfer!

@johno

This comment has been minimized.

Copy link
Owner

commented Jul 9, 2019

@johno are we deprecating this repo in favor of gatsby-theme-notes?

I plan on keeping this as a standalone set of themes to continue adding new features and functionality which we can move back into gatsby-theme-blog and gatsby-theme-notes when relevant for the larger ecosystem.

I would like to replace the internals of gatsby-theme-digital-garden by using gatsby-theme-notes as a parent theme.

@johno

This comment has been minimized.

Copy link
Owner

commented Jul 9, 2019

Thanks for the fix @adrw!

I'll add you and @johnletey as collaborators to the repo as well.

@johno johno merged commit 2f76740 into johno:master Jul 9, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details
@adrw

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 10, 2019

@johno Thanks for the merge and adding me as contributor!

@ChristopherBiscardi

This comment has been minimized.

Copy link
Collaborator

commented Jul 12, 2019

Dope, I love the idea of using this as a testing ground/child theme of gatsby-theme-notes. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.